netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phil Sutter <n0-1@freewrt.org>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jeff@garzik.org, florian@openwrt.org
Subject: [PATCH] korina: drop leftover assignment
Date: Thu, 15 Jan 2009 23:29:57 +0100	[thread overview]
Message-ID: <20090115223008.B784E4043837@mail.nwl.cc> (raw)
In-Reply-To: <1232058598-15811-2-git-send-email-n0-1@freewrt.org>

As the assigned value is being overwritten shortly after, it can be
dropped and so the whole variable definition moved to the start of the
function.

Signed-off-by: Phil Sutter <n0-1@freewrt.org>
---
 drivers/net/korina.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/drivers/net/korina.c b/drivers/net/korina.c
index 60ae7bf..75010ca 100644
--- a/drivers/net/korina.c
+++ b/drivers/net/korina.c
@@ -743,6 +743,7 @@ static struct ethtool_ops netdev_ethtool_ops = {
 static void korina_alloc_ring(struct net_device *dev)
 {
 	struct korina_private *lp = netdev_priv(dev);
+	struct sk_buff *skb;
 	int i;
 
 	/* Initialize the transmit descriptors */
@@ -758,8 +759,6 @@ static void korina_alloc_ring(struct net_device *dev)
 
 	/* Initialize the receive descriptors */
 	for (i = 0; i < KORINA_NUM_RDS; i++) {
-		struct sk_buff *skb = lp->rx_skb[i];
-
 		skb = dev_alloc_skb(KORINA_RBSIZE + 2);
 		if (!skb)
 			break;
-- 
1.5.6.4


  parent reply	other threads:[~2009-01-15 22:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1232058598-15811-1-git-send-email-n0-1@freewrt.org>
2009-01-15 22:29 ` [PATCH] korina: adjust headroom for new skb's also Phil Sutter
2009-01-19 21:07   ` Florian Fainelli
2009-01-20  0:23     ` David Miller
     [not found] ` <1232058598-15811-2-git-send-email-n0-1@freewrt.org>
2009-01-15 22:29   ` Phil Sutter [this message]
2009-01-19 21:07     ` [PATCH] korina: drop leftover assignment Florian Fainelli
2009-01-20  0:23       ` David Miller
     [not found]   ` <1232058598-15811-3-git-send-email-n0-1@freewrt.org>
2009-01-15 22:29     ` [PATCH] korina: set dev field of allocated socketbufs Phil Sutter
2009-01-19 21:08       ` Florian Fainelli
2009-01-20  0:24         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090115223008.B784E4043837@mail.nwl.cc \
    --to=n0-1@freewrt.org \
    --cc=davem@davemloft.net \
    --cc=florian@openwrt.org \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).