Re: [PATCH] PS3: gelic: convert to net_device_ops

[Masakazu Mokuno <mokuno@sm.sony.co.jp>]

On Thu, 15 Jan 2009 22:07:08 -0800
Stephen Hemminger <shemminger@vyatta.com> wrote:

> On Fri, 16 Jan 2009 13:57:15 +0900
> Masakazu Mokuno <mokuno@sm.sony.co.jp> wrote:
> 
> > Convert the gelic driver to net_device_ops
> > 
> > Signed-off-by: Masakazu Mokuno <mokuno@sm.sony.co.jp>
> > ---
> >  drivers/net/ps3_gelic_net.c |   23 +++++++++++++----------
> >  1 file changed, 13 insertions(+), 10 deletions(-)
> > 
> > --- a/drivers/net/ps3_gelic_net.c
> > +++ b/drivers/net/ps3_gelic_net.c
> > @@ -1403,6 +1403,18 @@ void gelic_net_tx_timeout(struct net_dev
> >  		atomic_dec(&card->tx_timeout_task_counter);
> >  }
> >  
> > +static const struct net_device_ops gelic_netdevice_ops = {
> > +	.ndo_open = gelic_net_open,
> > +	.ndo_stop = gelic_net_stop,
> > +	.ndo_start_xmit = gelic_net_xmit,
> > +	.ndo_set_multicast_list = gelic_net_set_multi,
> > +	.ndo_change_mtu = gelic_net_change_mtu,
> > +	.ndo_tx_timeout = gelic_net_tx_timeout,
> > +#ifdef CONFIG_NET_POLL_CONTROLLER
> > +	.ndo_poll_controller = gelic_net_poll_controller,
> > +#endif
> >
> 
> You probably want to add:
> 	.ndo_change_mtu		= eth_change_mtu,
> 	.ndo_set_mac_address 	= eth_mac_addr,
> 	.ndo_validate_addr	= eth_validate_addr,

Thanks!

I'll respin.

-- 
Masakazu Mokuno