From: David Miller <davem@davemloft.net>
To: klimes@centrum.cz
Cc: kaber@trash.net, netdev@vger.kernel.org
Subject: Re: XFRM structures binary compability
Date: Sat, 17 Jan 2009 23:13:34 -0800 (PST) [thread overview]
Message-ID: <20090117.231334.141351829.davem@davemloft.net> (raw)
In-Reply-To: <200901161440.3616@centrum.cz>
From: "Jiri Klimes" <klimes@centrum.cz>
Date: Fri, 16 Jan 2009 14:40:02 +0100
> David, I'm afraid the fix is not correct. xfrm_msg_min is not used
> just for length check, but mainly to find start of the netlink
> attributes. Therefore the patch will work for the case with no
> attributes. However it won't work properly in case attributes are
> used (which is in most cases). So, I suggest to revert the patch.
Thanks for catching this, I'll revert.
prev parent reply other threads:[~2009-01-18 7:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200901091324.3936@centrum.cz>
[not found] ` <200901091325.24572@centrum.cz>
[not found] ` <200901091326.18260@centrum.cz>
[not found] ` <200901091327.25342@centrum.cz>
[not found] ` <200901091328.6816@centrum.cz>
[not found] ` <200901091329.27638@centrum.cz>
[not found] ` <200901091330.17816@centrum.cz>
[not found] ` <200901091331.18342@centrum.cz>
2009-01-12 13:54 ` XFRM structures binary compability klimes
2009-01-12 14:41 ` Patrick McHardy
2009-01-14 22:55 ` David Miller
2009-01-16 13:40 ` Jiri Klimes
2009-01-17 11:27 ` Herbert Xu
2009-01-27 5:14 ` David Miller
2009-01-18 7:13 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090117.231334.141351829.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=klimes@centrum.cz \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).