From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH 3/4] dccp: Initialisation and type-checking of feature sysctls Date: Sun, 18 Jan 2009 21:40:25 -0800 (PST) Message-ID: <20090118.214025.262576583.davem@davemloft.net> References: <1232184993-9927-2-git-send-email-gerrit@erg.abdn.ac.uk> <1232184993-9927-3-git-send-email-gerrit@erg.abdn.ac.uk> <1232184993-9927-4-git-send-email-gerrit@erg.abdn.ac.uk> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: dccp@vger.kernel.org, netdev@vger.kernel.org To: gerrit@erg.abdn.ac.uk Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:36230 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755549AbZASFkX (ORCPT ); Mon, 19 Jan 2009 00:40:23 -0500 In-Reply-To: <1232184993-9927-4-git-send-email-gerrit@erg.abdn.ac.uk> Sender: netdev-owner@vger.kernel.org List-ID: From: Gerrit Renker Date: Sat, 17 Jan 2009 10:36:32 +0100 > This patch takes care of initialising and type-checking sysctls related to > feature negotiation. Type checking is important since some of the sysctls > now directly impact the feature-negotiation process. > > The sysctls are initialised with the known default values for each feature. > For the type-checking the value constraints from RFC 4340 are used: > > * Sequence Window uses the specified Wmin=32, the maximum is ulong (4 bytes), > tested and confirmed that it works up to 4294967295 - for Gbps speed; > * Ack Ratio is between 0 .. 0xffff (2-byte unsigned integer); > * CCIDs are between 0 .. 255; > * request_retries, retries1, retries2 also between 0..255 for good measure; > * tx_qlen is checked to be non-negative; > * sync_ratelimit remains as before. ... > Signed-off-by: Gerrit Renker > Acked-by: Ian McDonald Applied for 2.6.30