From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: bhutchings@solarflare.com, netdev@vger.kernel.org
Subject: Re: sfc: Replace LRO with GRO
Date: Sun, 18 Jan 2009 21:50:27 -0800 (PST) [thread overview]
Message-ID: <20090118.215027.46669769.davem@davemloft.net> (raw)
In-Reply-To: <20090115042422.GB29658@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 15 Jan 2009 15:24:22 +1100
> sfc: Replace LRO with GRO
>
> This patch makes sfc invoke the GRO hooks instead of LRO. As
> GRO has a compatible external interface to LRO this is a very
> straightforward replacement.
>
> Everything should appear identical to the user except that the
> offload is now controlled by the GRO ethtool option instead of
> LRO. I've kept the lro module parameter as is since that's for
> compatibility only.
>
> I have eliminated efx_rx_mk_skb as the GRO layer can take care
> of all packets regardless of whether GRO is enabled or not.
>
> So the only case where we don't call GRO is if the packet checksum
> is absent. This is to keep the behaviour changes of the patch to
> a minimum.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied for 2.6.30
next prev parent reply other threads:[~2009-01-19 5:50 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 9:26 [1/2] e1000e: Invoke VLAN GRO handler Herbert Xu
2009-01-13 9:28 ` [2/2] igb: Replace LRO with GRO Herbert Xu
2009-01-14 8:44 ` ixgbe: " Herbert Xu
2009-01-14 11:53 ` Jeff Kirsher
2009-01-15 3:46 ` Herbert Xu
2009-01-15 4:22 ` Herbert Xu
2009-01-19 5:49 ` David Miller
2009-01-16 23:32 ` Jeff Kirsher
2009-01-17 0:36 ` Herbert Xu
2009-01-17 1:06 ` Tantilov, Emil S
2009-01-17 3:45 ` Herbert Xu
2009-01-17 8:07 ` Tantilov, Emil S
2009-01-17 9:52 ` Herbert Xu
2009-01-17 13:04 ` Herbert Xu
2009-01-20 23:00 ` Tantilov, Emil S
2009-01-17 15:44 ` Tantilov, Emil S
2009-01-14 11:49 ` [2/2] igb: " Jeff Kirsher
2009-01-14 12:36 ` Herbert Xu
2009-01-15 0:03 ` Jeff Kirsher
2009-01-15 0:32 ` Herbert Xu
2009-01-15 1:35 ` Jeff Kirsher
2009-01-15 1:56 ` David Miller
2009-01-15 2:02 ` Jeff Kirsher
2009-01-15 4:40 ` David Miller
2009-01-19 5:47 ` David Miller
2009-01-19 11:16 ` Herbert Xu
2009-01-19 22:34 ` Jeff Kirsher
2009-01-19 23:21 ` David Miller
2009-01-15 4:24 ` sfc: " Herbert Xu
2009-01-19 5:50 ` David Miller [this message]
2009-01-19 14:40 ` Ben Hutchings
2009-01-19 21:29 ` David Miller
2009-01-19 22:12 ` Harvey Harrison
2009-01-19 23:27 ` David Miller
2009-01-20 0:57 ` Stephen Rothwell
2009-01-15 4:38 ` [1/2] e1000e: Invoke VLAN GRO handler David Miller
2009-01-15 6:59 ` cxgb3: Replace LRO with GRO Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090118.215027.46669769.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bhutchings@solarflare.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).