* [PATCH 2.6.28] cxgb3 - Fix LRO misalignment
@ 2009-01-16 0:48 Divy Le Ray
2009-01-16 1:57 ` Rick Jones
0 siblings, 1 reply; 4+ messages in thread
From: Divy Le Ray @ 2009-01-16 0:48 UTC (permalink / raw)
To: davem; +Cc: netdev, linux-kernel, swise, leedom, rick.jones2
From: Divy Le Ray <divy@chelsio.com>
The lro manager's frag_align_pad setting was missing,
leading to misaligned access to the skb passed up
to the stack.
Signed-off-by: Divy Le Ray <divy@chelsio.com>
---
drivers/net/cxgb3/sge.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/cxgb3/sge.c b/drivers/net/cxgb3/sge.c
index 14f9fb3..379a132 100644
--- a/drivers/net/cxgb3/sge.c
+++ b/drivers/net/cxgb3/sge.c
@@ -2104,6 +2104,7 @@ static void init_lro_mgr(struct sge_qset *qs, struct net_lro_mgr *lro_mgr)
{
lro_mgr->dev = qs->netdev;
lro_mgr->features = LRO_F_NAPI;
+ lro_mgr->frag_align_pad = NET_IP_ALIGN;
lro_mgr->ip_summed = CHECKSUM_UNNECESSARY;
lro_mgr->ip_summed_aggr = CHECKSUM_UNNECESSARY;
lro_mgr->max_desc = T3_MAX_LRO_SES;
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.28] cxgb3 - Fix LRO misalignment
2009-01-16 0:48 [PATCH 2.6.28] cxgb3 - Fix LRO misalignment Divy Le Ray
@ 2009-01-16 1:57 ` Rick Jones
2009-01-16 19:05 ` Divy Le Ray
0 siblings, 1 reply; 4+ messages in thread
From: Rick Jones @ 2009-01-16 1:57 UTC (permalink / raw)
To: Divy Le Ray; +Cc: davem, netdev, linux-kernel, swise, leedom
Divy Le Ray wrote:
> From: Divy Le Ray <divy@chelsio.com>
>
> The lro manager's frag_align_pad setting was missing,
> leading to misaligned access to the skb passed up
> to the stack.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
I have tried this in a tree I have, and where I was once seeing unaligned access
messages on an ia64 system with LRO enabled, now I see none.
Tested-by: Rick Jones <rick.jones2@hp.com>
rick jones
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.28] cxgb3 - Fix LRO misalignment
2009-01-16 1:57 ` Rick Jones
@ 2009-01-16 19:05 ` Divy Le Ray
2009-01-19 6:01 ` David Miller
0 siblings, 1 reply; 4+ messages in thread
From: Divy Le Ray @ 2009-01-16 19:05 UTC (permalink / raw)
To: Rick Jones; +Cc: davem, netdev, linux-kernel, Steve Wise, Casey Leedom
Rick Jones wrote:
> Divy Le Ray wrote:
>
>> From: Divy Le Ray <divy@chelsio.com>
>>
>> The lro manager's frag_align_pad setting was missing,
>> leading to misaligned access to the skb passed up
>> to the stack.
>>
>> Signed-off-by: Divy Le Ray <divy@chelsio.com>
>>
>
> I have tried this in a tree I have, and where I was once seeing unaligned access
> messages on an ia64 system with LRO enabled, now I see none.
>
> Tested-by: Rick Jones <rick.jones2@hp.com>
>
> rick jones
>
>
Hi Dave,
The patch is intended for 2.6.29, not 2.6.28 as the subject mistakenly
states.
Cheers,
Divy
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 2.6.28] cxgb3 - Fix LRO misalignment
2009-01-16 19:05 ` Divy Le Ray
@ 2009-01-19 6:01 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2009-01-19 6:01 UTC (permalink / raw)
To: divy; +Cc: rick.jones2, netdev, linux-kernel, swise, leedom
From: Divy Le Ray <divy@chelsio.com>
Date: Fri, 16 Jan 2009 11:05:50 -0800
> The patch is intended for 2.6.29, not 2.6.28 as the subject mistakenly states.
Understood, applied, thanks everyone.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-01-19 6:01 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-16 0:48 [PATCH 2.6.28] cxgb3 - Fix LRO misalignment Divy Le Ray
2009-01-16 1:57 ` Rick Jones
2009-01-16 19:05 ` Divy Le Ray
2009-01-19 6:01 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).