From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, jeff@garzik.org,
jesse.brandeburg@intel.com, bruce.w.allan@intel.com,
donash4@gmail.com
Subject: Re: [PATCH] e1000e: drop lltx, remove unnecessary lock
Date: Mon, 19 Jan 2009 16:52:20 -0800 (PST) [thread overview]
Message-ID: <20090119.165220.120345185.davem@davemloft.net> (raw)
In-Reply-To: <20090120001708.22703.8019.stgit@lost.foo-projects.org>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 19 Jan 2009 16:17:08 -0800
> LLTX is deprecated and complicated, don't use it. It was observed by Don Ash
> <donash4@gmail.com> that e1000e was acquiring this lock in the NAPI cleanup
> path. This is obviously a bug, as this is a leftover from when e1000
> supported multiple tx queues and fake netdevs.
>
> another user reported this to us and tested routing with the 2.6.27 kernel and
> this patch and reported a 3.5 % improvement in packets forwarded in a
> multi-port test on 82571 parts.
>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@intel.com>
> Signed-off-by: Bruce Allan <bruce.w.allan@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Nice, applied.
One down, 16 to go. The following drivers are on notice :-)
drivers/net/atl1e/atl1e_main.c
drivers/net/bonding/bond_main.c
drivers/net/chelsio/cxgb2.c
drivers/net/cris/eth_v10.c
drivers/net/cxgb3/cxgb3_main.c
drivers/net/e1000/e1000_main.c
drivers/net/ehea/ehea_main.c
drivers/net/ibmveth.c
drivers/net/igb/igb_main.c
drivers/net/loopback.c
drivers/net/pasemi_mac.c
drivers/net/rionet.c
drivers/net/spider_net.c
drivers/net/sungem.c
drivers/net/tehuti.c
drivers/net/veth.c
prev parent reply other threads:[~2009-01-20 0:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 0:17 [PATCH] e1000e: drop lltx, remove unnecessary lock Jeff Kirsher
2009-01-20 0:52 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119.165220.120345185.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=bruce.w.allan@intel.com \
--cc=donash4@gmail.com \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).