From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, jeff@garzik.org, peter.p.waskiewicz.jr@intel.com
Subject: Re: [PATCH 3/3] ixgbe: Fix usage of netif_*_all_queues() with netif_carrier_{off|on}()
Date: Mon, 19 Jan 2009 16:55:30 -0800 (PST) [thread overview]
Message-ID: <20090119.165530.190679813.davem@davemloft.net> (raw)
In-Reply-To: <20090120001147.22544.97470.stgit@lost.foo-projects.org>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Mon, 19 Jan 2009 16:11:47 -0800
> netif_carrier_off() is sufficient to stop Tx into the driver. Stopping the Tx
> queues is redundant and unnecessary. By the same token, netif_carrier_on()
> will be sufficient to re-enable Tx, so waking the queues is unnecessary.
>
> Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2009-01-20 0:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 0:11 [PATCH 1/3] ixgbe: fix dca issue with relaxed ordering turned on Jeff Kirsher
2009-01-20 0:11 ` [PATCH 2/3] ixgbe: fix tag stripping for VLAN ID 0 Jeff Kirsher
2009-01-20 0:55 ` David Miller
2009-01-20 0:11 ` [PATCH 3/3] ixgbe: Fix usage of netif_*_all_queues() with netif_carrier_{off|on}() Jeff Kirsher
2009-01-20 0:55 ` David Miller [this message]
2009-01-20 0:55 ` [PATCH 1/3] ixgbe: fix dca issue with relaxed ordering turned on David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119.165530.190679813.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).