From: David Miller <davem@davemloft.net>
To: buytenh@wantstofly.org
Cc: tbm@cyrius.com, pacman@kosh.dhis.org, netdev@vger.kernel.org,
matt@genesi-usa.com, paubert@iram.es
Subject: Re: [PATCH] mv643xx_eth: fix multicast filter programming
Date: Mon, 19 Jan 2009 17:17:24 -0800 (PST) [thread overview]
Message-ID: <20090119.171724.169700515.davem@davemloft.net> (raw)
In-Reply-To: <20090119095813.GF17124@xi.wantstofly.org>
From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Mon, 19 Jan 2009 10:58:13 +0100
> Commit 66e63ffbc04706568d8789cbb00eaa8ddbcae648 ("mv643xx_eth:
> implement ->set_rx_mode()") cleaned up mv643xx_eth's multicast filter
> programming, but broke it as well.
>
> The non-special multicast filter table (for multicast addresses that
> are not of the form 01:00:5e:00:00:xx) consists of 256 hash table
> buckets organised as 64 32-bit words, where the 'accept' bits are
> in the LSB of each byte, so in bits 24 16 8 0 of each 32-bit word.
> The old code got this right, but the referenced commit broke this by
> using bits 3 2 1 0 instead. This commit fixes this up.
>
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Applied.
prev parent reply other threads:[~2009-01-20 1:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 9:58 [PATCH] mv643xx_eth: fix multicast filter programming Lennert Buytenhek
2009-01-20 1:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119.171724.169700515.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=buytenh@wantstofly.org \
--cc=matt@genesi-usa.com \
--cc=netdev@vger.kernel.org \
--cc=pacman@kosh.dhis.org \
--cc=paubert@iram.es \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).