From: David Miller <davem@davemloft.net>
To: buytenh@wantstofly.org
Cc: tbm@cyrius.com, pacman@kosh.dhis.org, netdev@vger.kernel.org,
matt@genesi-usa.com, paubert@iram.es
Subject: Re: [PATCH] mv643xx_eth: prevent interrupt storm on ifconfig down
Date: Mon, 19 Jan 2009 17:18:19 -0800 (PST) [thread overview]
Message-ID: <20090119.171819.17901719.davem@davemloft.net> (raw)
In-Reply-To: <20090119100921.GG17124@xi.wantstofly.org>
From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Mon, 19 Jan 2009 11:09:21 +0100
> From: Gabriel Paubert <paubert@iram.es>
>
> Contrary to what the docs say, the 'extended interrupt cause' bit in
> the interrupt cause register (bit 1) appears to not be maskable on at
> least some of the mv643xx_eth platforms, making writing zeroes to the
> interrupt mask register but not the extended interrupt mask register
> insufficient to stop interrupts from occuring. Therefore, also write
> zeroes to the extended interrupt mask register when shutting down the
> port.
>
> This fixes the interrupt storm seen on the Pegasos board when shutting
> down the interface.
>
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Also applied, thanks.
prev parent reply other threads:[~2009-01-20 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 10:09 [PATCH] mv643xx_eth: prevent interrupt storm on ifconfig down Lennert Buytenhek
2009-01-20 1:18 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119.171819.17901719.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=buytenh@wantstofly.org \
--cc=matt@genesi-usa.com \
--cc=netdev@vger.kernel.org \
--cc=pacman@kosh.dhis.org \
--cc=paubert@iram.es \
--cc=tbm@cyrius.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).