* [PATCH] mv643xx_eth: prevent interrupt storm on ifconfig down
@ 2009-01-19 10:09 Lennert Buytenhek
2009-01-20 1:18 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Lennert Buytenhek @ 2009-01-19 10:09 UTC (permalink / raw)
To: David Miller; +Cc: tbm, pacman, netdev, Matt Sealey, Gabriel Paubert
From: Gabriel Paubert <paubert@iram.es>
Contrary to what the docs say, the 'extended interrupt cause' bit in
the interrupt cause register (bit 1) appears to not be maskable on at
least some of the mv643xx_eth platforms, making writing zeroes to the
interrupt mask register but not the extended interrupt mask register
insufficient to stop interrupts from occuring. Therefore, also write
zeroes to the extended interrupt mask register when shutting down the
port.
This fixes the interrupt storm seen on the Pegasos board when shutting
down the interface.
Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
---
drivers/net/mv643xx_eth.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/mv643xx_eth.c b/drivers/net/mv643xx_eth.c
index 8c6979a..5f31bbb 100644
--- a/drivers/net/mv643xx_eth.c
+++ b/drivers/net/mv643xx_eth.c
@@ -2212,6 +2212,7 @@ static int mv643xx_eth_stop(struct net_device *dev)
struct mv643xx_eth_private *mp = netdev_priv(dev);
int i;
+ wrlp(mp, INT_MASK_EXT, 0x00000000);
wrlp(mp, INT_MASK, 0x00000000);
rdlp(mp, INT_MASK);
--
1.5.6.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mv643xx_eth: prevent interrupt storm on ifconfig down
2009-01-19 10:09 [PATCH] mv643xx_eth: prevent interrupt storm on ifconfig down Lennert Buytenhek
@ 2009-01-20 1:18 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-01-20 1:18 UTC (permalink / raw)
To: buytenh; +Cc: tbm, pacman, netdev, matt, paubert
From: Lennert Buytenhek <buytenh@wantstofly.org>
Date: Mon, 19 Jan 2009 11:09:21 +0100
> From: Gabriel Paubert <paubert@iram.es>
>
> Contrary to what the docs say, the 'extended interrupt cause' bit in
> the interrupt cause register (bit 1) appears to not be maskable on at
> least some of the mv643xx_eth platforms, making writing zeroes to the
> interrupt mask register but not the extended interrupt mask register
> insufficient to stop interrupts from occuring. Therefore, also write
> zeroes to the extended interrupt mask register when shutting down the
> port.
>
> This fixes the interrupt storm seen on the Pegasos board when shutting
> down the interface.
>
> Signed-off-by: Lennert Buytenhek <buytenh@marvell.com>
Also applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-01-20 1:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-19 10:09 [PATCH] mv643xx_eth: prevent interrupt storm on ifconfig down Lennert Buytenhek
2009-01-20 1:18 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).