From: David Miller <davem@davemloft.net>
To: david-b@pacbell.net
Cc: netdev@vger.kernel.org, steve.glendinning@smsc.com,
ian.saturley@smsc.com, jeff@garzik.org
Subject: Re: [patch 2.6.29-rc] usbnet: allow type check of devdbg arguments in non-debug build
Date: Mon, 19 Jan 2009 17:57:30 -0800 (PST) [thread overview]
Message-ID: <20090119.175730.262402885.davem@davemloft.net> (raw)
In-Reply-To: <20090119.171200.235073814.davem@davemloft.net>
From: David Miller <davem@davemloft.net>
Date: Mon, 19 Jan 2009 17:12:00 -0800 (PST)
> From: David Brownell <david-b@pacbell.net>
> Date: Fri, 16 Jan 2009 23:19:44 -0800
>
> > Improve usbnet's devdbg to always type-check diagnostic arguments,
> > like dev_dbg (device.h). This makes no change to the resulting size of
> > usbnet modules.
> >
> > Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
> > Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
>
> Applied, thanks.
I have to back this out, it breaks the build:
drivers/net/wireless/rndis_wlan.c: In function 'rndis_translate_scan':
drivers/net/wireless/rndis_wlan.c:1664: error: 'usbdev' undeclared (first use in this function)
drivers/net/wireless/rndis_wlan.c:1664: error: (Each undeclared identifier is reported only once
drivers/net/wireless/rndis_wlan.c:1664: error: for each function it appears in.)
make[3]: *** [drivers/net/wireless/rndis_wlan.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[2]: *** [drivers/net/wireless] Error 2
make[2]: *** Waiting for unfinished jobs....
I bet there are other similar gremlins like this in the tree.
next prev parent reply other threads:[~2009-01-20 1:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 15:47 [PATCH 1/1] usbnet: allow type check of devdbg arguments in non-debug build Steve Glendinning
2008-09-25 2:14 ` Jeff Garzik
2009-01-17 7:19 ` [patch 2.6.29-rc] " David Brownell
2009-01-20 1:12 ` David Miller
2009-01-20 1:57 ` David Miller [this message]
2009-01-20 2:04 ` David Brownell
2009-01-20 4:08 ` David Miller
2009-01-20 5:11 ` David Brownell
2009-01-20 10:56 ` Steve.Glendinning
2009-01-20 17:19 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119.175730.262402885.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=david-b@pacbell.net \
--cc=ian.saturley@smsc.com \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).