From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Steve Glendinning <steve.glendinning@smsc.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>,
Stanley Miao <stanley.miao@windriver.com>,
Ian Saturley <ian.saturley@smsc.com>
Subject: Re: [PATCH 5/5] arm: convert omap ldp platform to use smsc911x
Date: Mon, 19 Jan 2009 22:35:41 +0000 [thread overview]
Message-ID: <20090119223541.GK18301@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1232010482-3744-6-git-send-email-steve.glendinning@smsc.com>
On Thu, Jan 15, 2009 at 09:08:02AM +0000, Steve Glendinning wrote:
> - ldp_smc911x_resources[0].start = cs_mem_base + 0x0;
> - ldp_smc911x_resources[0].end = cs_mem_base + 0xf;
> + ldp_smsc911x_resources[0].start = cs_mem_base + 0x0;
> + ldp_smsc911x_resources[0].end = cs_mem_base + 0xf;
Actually, having finally got around to checking whether the smc911x
support submitted from the OMAP folk on the LDP board works, I find
it doesn't.
And the reason it doesn't is that SMC911x wants to claim 256 bytes
of space in this resource. With only 16 bytes in the parent resource,
that isn't going to work.
It looks to me like this is wrong for the SMSC911x driver as well.
davem - I can see if I merge a fix for this (once I have confirmation
what the fix should be) and push it for -rc, that will make things a
little more complicated at your end. Suggest we hold fire on these
patches for a few more days.
next prev parent reply other threads:[~2009-01-19 22:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-15 9:07 [PATCH REPOST 0/5] convert arm platforms to smsc911x Steve Glendinning
2009-01-15 9:07 ` [PATCH 1/5] smsc911x: add support for platform-specific irq flags Steve Glendinning
2009-01-15 9:07 ` [PATCH 2/5] smsc911x: register isr as IRQF_SHARED Steve Glendinning
2009-01-15 9:08 ` [PATCH 3/5] arm: convert pcm037 platform to use smsc911x Steve Glendinning
2009-01-15 9:08 ` [PATCH 4/5] arm: convert realview " Steve Glendinning
2009-01-15 9:08 ` [PATCH 5/5] arm: convert omap ldp " Steve Glendinning
2009-01-15 9:23 ` stanley.miao
2009-01-19 22:35 ` Russell King - ARM Linux [this message]
2009-01-20 0:30 ` David Miller
2009-01-19 5:53 ` [PATCH REPOST 0/5] convert arm platforms to smsc911x David Miller
2009-01-19 8:04 ` stanley.miao
2009-01-19 9:22 ` Russell King - ARM Linux
2009-01-19 9:53 ` Steve.Glendinning
2009-01-19 21:15 ` David Miller
2009-01-19 21:31 ` Russell King - ARM Linux
2009-01-19 22:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119223541.GK18301@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=davem@davemloft.net \
--cc=ian.saturley@smsc.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=stanley.miao@windriver.com \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).