netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: steve.glendinning@smsc.com
Cc: netdev@vger.kernel.org, david-b@pacbell.net
Subject: Re: [PATCH 1/2] rndis_wlan: allow devdbg arguments to be type-checked without DEBUG
Date: Tue, 20 Jan 2009 09:06:10 -0800 (PST)	[thread overview]
Message-ID: <20090120.090610.163846658.davem@davemloft.net> (raw)
In-Reply-To: <1232456838-10025-1-git-send-email-steve.glendinning@smsc.com>

From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Tue, 20 Jan 2009 13:07:17 +0000

> This patch removes an #ifdef DEBUG directive so devdbg statements can be
> type-checked at compile time.  Type checking itself is introduced by
> another patch in this series.
> 
> This introduces an unused variable warning which disappears with the
> type-checking patch.
> 
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>

This adds a warning for the non-DEBUG build.  That's the whole reason
the ifdef is there.

Therefore you must do the devdbg() define change and this ifdef
removal in the same commit.

      parent reply	other threads:[~2009-01-20 17:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 13:07 [PATCH 1/2] rndis_wlan: allow devdbg arguments to be type-checked without DEBUG Steve Glendinning
2009-01-20 13:07 ` [PATCH 2/2] usbnet: allow type check of devdbg arguments in non-debug build Steve Glendinning
2009-01-20 17:06 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090120.090610.163846658.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=david-b@pacbell.net \
    --cc=netdev@vger.kernel.org \
    --cc=steve.glendinning@smsc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).