From: David Miller <davem@davemloft.net>
To: arnd@arndb.de
Cc: ceggers@gmx.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers
Date: Tue, 20 Jan 2009 15:23:45 -0800 (PST) [thread overview]
Message-ID: <20090120.152345.78877396.davem@davemloft.net> (raw)
In-Reply-To: <200901210017.19038.arnd@arndb.de>
From: Arnd Bergmann <arnd@arndb.de>
Date: Wed, 21 Jan 2009 00:17:18 +0100
> On Tuesday 20 January 2009, David Miller wrote:
> > + buffer = kmalloc(size, GFP_NOIO);
>
> GFP_NOIO seems out of place in a network driver: there is nothing
> wrong with waiting for I/O here, so plain GFP_KERNEL should be fine.
There seems to be a large precendence for this in other USB drivers,
both for networking and storage. Probably a mutex or other locking
hierarchy issue.
Really, I would just apply this patch as-is. It works, it's pretty
clean, and every retort has been a misunderstanding or extreme
nit-picking :-)
next prev parent reply other threads:[~2009-01-20 23:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 20:29 [PATCH] usb/mcs7830: Don't use buffers from stack for USB transfers Christian Eggers
2009-01-20 20:32 ` David Miller
2009-01-20 22:45 ` Arnd Bergmann
2009-01-20 22:47 ` David Miller
2009-01-20 23:17 ` Arnd Bergmann
2009-01-20 23:23 ` David Miller [this message]
2009-01-20 23:36 ` Oliver Neukum
2009-01-20 23:37 ` Arnd Bergmann
2009-01-20 23:39 ` David Miller
2009-01-20 23:28 ` Oliver Neukum
2009-01-20 22:50 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120.152345.78877396.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=ceggers@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).