From: David Miller <davem@davemloft.net>
To: sam@ravnborg.org
Cc: jaswinderlinux@gmail.com, khc@pm.waw.pl, jaswinder@kernel.org,
arnd@arndb.de, mingo@elte.hu, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: why usr/include/linux/if_frad.h is required
Date: Tue, 20 Jan 2009 22:15:04 -0800 (PST) [thread overview]
Message-ID: <20090120.221504.264090722.davem@davemloft.net> (raw)
In-Reply-To: <20090121053310.GA26395@uranus.ravnborg.org>
From: Sam Ravnborg <sam@ravnborg.org>
Date: Wed, 21 Jan 2009 06:33:10 +0100
> On Wed, Jan 21, 2009 at 10:20:17AM +0530, Jaswinder Singh Rajput wrote:
> > On Wed, Jan 21, 2009 at 6:36 AM, Krzysztof Halasa <khc@pm.waw.pl> wrote:
> > > Jaswinder Singh Rajput <jaswinder@kernel.org> writes:
> > >
> > >> usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years
> > >> and no body is complaining about it so it means no body is using it.
> > >>
> > >> So should we need to drop #if / #endif pair or the whole file from
> > >> userspace.
> > >
> > > I think the file. "Empty file exported to userspace", long unused. We
> > > can also have it back there, and it being not exported is an indicator
> > > that it's not used. I guess the #ifdef __KERNEL__ can be removed, too.
> >
> > I will definately define #ifdef __KERNEL__ but I am also curious after
> > defining it there is no point of making empty
> > usr/include/linux/if_frad.h
>
> Googling a bit did not turn up _any_ non-kernel hits that has relevance.
> So based on the information given in this thread I strongly
> suggest to drop the export of this header.
Sure, but on the other hand this makes all of the userland APIs
essentially inaccessible and undefined.
I bet Sangoma's internal tools reference this stuff.
next prev parent reply other threads:[~2009-01-21 6:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 14:52 why usr/include/linux/if_frad.h is required Jaswinder Singh Rajput
2009-01-20 14:54 ` Jaswinder Singh Rajput
2009-01-20 17:47 ` Arnd Bergmann
2009-01-20 19:53 ` Krzysztof Halasa
2009-01-20 23:48 ` Jaswinder Singh Rajput
2009-01-21 1:06 ` Krzysztof Halasa
2009-01-21 4:50 ` Jaswinder Singh Rajput
2009-01-21 5:33 ` Sam Ravnborg
2009-01-21 6:15 ` David Miller [this message]
2009-01-21 6:38 ` Stephen Hemminger
2009-01-21 23:37 ` David Miller
2009-01-22 5:37 ` Sam Ravnborg
2009-01-24 13:25 ` Jaswinder Singh Rajput
2009-01-24 15:32 ` Krzysztof Halasa
2009-01-26 20:30 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120.221504.264090722.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=arnd@arndb.de \
--cc=jaswinder@kernel.org \
--cc=jaswinderlinux@gmail.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).