From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: why usr/include/linux/if_frad.h is required Date: Tue, 20 Jan 2009 22:15:04 -0800 (PST) Message-ID: <20090120.221504.264090722.davem@davemloft.net> References: <3f9a31f40901202050u4b85fef2p8b9848b865c4fda0@mail.gmail.com> <20090121053310.GA26395@uranus.ravnborg.org> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: jaswinderlinux@gmail.com, khc@pm.waw.pl, jaswinder@kernel.org, arnd@arndb.de, mingo@elte.hu, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: sam@ravnborg.org Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:54120 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751055AbZAUGPD (ORCPT ); Wed, 21 Jan 2009 01:15:03 -0500 In-Reply-To: <20090121053310.GA26395@uranus.ravnborg.org> Sender: netdev-owner@vger.kernel.org List-ID: From: Sam Ravnborg Date: Wed, 21 Jan 2009 06:33:10 +0100 > On Wed, Jan 21, 2009 at 10:20:17AM +0530, Jaswinder Singh Rajput wrote: > > On Wed, Jan 21, 2009 at 6:36 AM, Krzysztof Halasa wrote: > > > Jaswinder Singh Rajput writes: > > > > > >> usr/include/linux/if_frad.h is covered with CONFIG_DLCI from many years > > >> and no body is complaining about it so it means no body is using it. > > >> > > >> So should we need to drop #if / #endif pair or the whole file from > > >> userspace. > > > > > > I think the file. "Empty file exported to userspace", long unused. We > > > can also have it back there, and it being not exported is an indicator > > > that it's not used. I guess the #ifdef __KERNEL__ can be removed, too. > > > > I will definately define #ifdef __KERNEL__ but I am also curious after > > defining it there is no point of making empty > > usr/include/linux/if_frad.h > > Googling a bit did not turn up _any_ non-kernel hits that has relevance. > So based on the information given in this thread I strongly > suggest to drop the export of this header. Sure, but on the other hand this makes all of the userland APIs essentially inaccessible and undefined. I bet Sangoma's internal tools reference this stuff.