From: Sascha Hauer <s.hauer@pengutronix.de>
To: Steve Glendinning <steve.glendinning@smsc.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, netdev@vger.kernel.org,
David Miller <davem@davemloft.net>,
Russell King <linux@arm.linux.org.uk>,
Stanley Miao <stanley.miao@windriver.com>,
Ian Saturley <ian.saturley@smsc.com>
Subject: Re: [PATCH 3/6] arm: convert pcm037 platform to use smsc911x
Date: Tue, 20 Jan 2009 16:29:51 +0100 [thread overview]
Message-ID: <20090120152951.GB21134@pengutronix.de> (raw)
In-Reply-To: <1232458114-10997-4-git-send-email-steve.glendinning@smsc.com>
I just gave it a try on our pcm037 board and it turns out that it
doesn't work.
The reason for this is not the driver, it's just that the hardware
designers got the direction of the phy detect pin wrong. The pcm037 uses
an internal phy, but the detection pin is pulled high :(
The old driver worked around this by falling back to the internal phy
when no valid phy id is detected. The new driver lacks this fallback.
Instead of falling back we could also introduce a
SMSC911X_FORCE_INTERNAL_PHY flag.
What do you think?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2009-01-20 15:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-20 13:28 [PATCH REPOST 0/6] convert arm platforms to smsc911x Steve Glendinning
2009-01-20 13:28 ` [PATCH 1/6] smsc911x: add support for platform-specific irq flags Steve Glendinning
2009-01-20 13:28 ` [PATCH 2/6] smsc911x: register isr as IRQF_SHARED Steve Glendinning
2009-01-20 13:28 ` [PATCH 3/6] arm: convert pcm037 platform to use smsc911x Steve Glendinning
2009-01-20 13:28 ` [PATCH 4/6] arm: convert realview " Steve Glendinning
2009-01-20 13:28 ` [PATCH 5/6] arm: update pcm037 defconfig " Steve Glendinning
2009-01-20 13:28 ` [PATCH 6/6] arm: update realview defconfigs " Steve Glendinning
2009-01-20 13:44 ` [PATCH 4/6] arm: convert realview platform " Catalin Marinas
2009-01-20 15:29 ` Sascha Hauer [this message]
2009-01-20 17:13 ` [PATCH 3/6] arm: convert pcm037 " David Miller
2009-01-21 10:58 ` Mark Brown
2009-01-21 14:38 ` Sascha Hauer
2009-01-20 14:55 ` [PATCH 1/6] smsc911x: add support for platform-specific irq flags Ben Dooks
2009-01-21 15:54 ` Steve.Glendinning
2009-01-26 1:45 ` David Miller
2009-01-26 8:45 ` Steve.Glendinning
2009-01-21 3:06 ` [PATCH 7/8] arm: convert omap ldp platform to use smsc911x Stanley.Miao
2009-01-21 3:06 ` [PATCH 8/8] arm: update omap_ldp defconfig " Stanley.Miao
2009-01-22 10:58 ` [PATCH 7/8] arm: convert omap ldp platform " Russell King - ARM Linux
2009-01-24 4:14 ` stanley.miao
2009-01-23 17:07 ` Steve.Glendinning
2009-01-24 4:16 ` stanley.miao
2009-01-24 3:38 ` [PATCHv2 " Stanley.Miao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090120152951.GB21134@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=davem@davemloft.net \
--cc=ian.saturley@smsc.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=stanley.miao@windriver.com \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).