Re: [PATCH 02/21] [next] qlge: Add new functions for signaling link up/down.

[Ron Mercer <ron.mercer@qlogic.com>]

On Fri, Jan 23, 2009 at 03:23:33PM -0800, Ben Hutchings wrote:
> On Fri, 2009-01-23 at 07:16 -0800, Ron Mercer wrote:
> > Centralize this call as it will also be used by firmware events.
> > 
> > Signed-off-by: Ron Mercer <ron.mercer@qlogic.com>
> > ---
> >  drivers/net/qlge/qlge_main.c |   38 ++++++++++++++++++++++++--------------
> >  1 files changed, 24 insertions(+), 14 deletions(-)
> > 
> > diff --git a/drivers/net/qlge/qlge_main.c b/drivers/net/qlge/qlge_main.c
> > index a530f5b..e6f9146 100644
> > --- a/drivers/net/qlge/qlge_main.c
> > +++ b/drivers/net/qlge/qlge_main.c
> > @@ -240,6 +240,24 @@ exit:
> >  	return status;
> >  }
> >  
> > +static void ql_link_on(struct ql_adapter *qdev)
> > +{
> > +	if (!netif_carrier_ok(qdev->ndev)) {
> > +		QPRINTK(qdev, LINK, INFO, "Link is Up.\n");
> > +		netif_carrier_on(qdev->ndev);
> > +		netif_wake_queue(qdev->ndev);
> > +	}
> > +}
> > +
> > +static void ql_link_off(struct ql_adapter *qdev)
> > +{
> > +	if (netif_carrier_ok(qdev->ndev)) {
> > +		QPRINTK(qdev, LINK, INFO, "Link is Down.\n");
> > +		netif_carrier_off(qdev->ndev);
> > +		netif_stop_queue(qdev->ndev);
> > +	}
> > +}
> > +
> 
> netif_{wake,stop_queue}() are redundant with netif_carrier_{on,off}() so
> I think this patch is (mostly?) unnecessary.
> 
> Ben.
> 
> -- 
> Ben Hutchings, Senior Software Engineer, Solarflare Communications
> Not speaking for my employer; that's the marketing department's job.
> They asked us to note that Solarflare product names are trademarked.

Yes, I see that some of the other drivers got rid of the
start/stop/wake.  If I have to re-submit this patch series I will remove
those lines.  If Dave accepts these patches then I will remove the lines
in my next series.

Thanks,
Ron