Re: [PATCH] IPv6 multicast routing

[David Miller <davem@davemloft.net>]

From: "Goff, Thomas" <Thomas.Goff@boeing.com>
Date: Thu, 22 Jan 2009 15:30:38 -0800

> On Wed, Jan 21, 2009 at 10:04:31AM +0900, YOSHIFUJI Hideaki / 吉藤英明 wrote:
> 
> > >   - Enable/disable IPv6 multicast forwarding on the corresponding
> > >     interface when a routing daemon adds/removes a multicast virtual
> > >     interface.
> :
> > However, I believe configuring forwarding is user's responsibility
> > and I'm not in favor of managing mc_forwarding automatically.
> >
> > If we go your way, we need to make the proc interface read-only, but
> > you know, they will become non-"conf" interface. :-(
> > And, well, we will introduce another possible overflow/underflow here...
> >
> > Another thought was to allow non-VIF routing settings (or manual settings).
> >
> > So, I decided to drop that bits.
> 
> Thanks for looking it over.
> 
> I think your approach to handling mc_forwarding makes sense, although
> it differs from the IPv4 behavior.  In any case, it looks like the
> current IPv4 and IPv6 multicast routing code does not consider an
> interface's mc_forwarding value at all.

Thanks guys.

Hideaki-san, did you queue this patch up or do you want me to
apply it with the mc_forwarding counter bumps removed?

These are bug fixes so I'd like to see this in the tree soon.