* VLAN patch: Export symbols as non GPL symbols.
@ 2009-01-26 17:01 Ben Greear
2009-01-26 17:05 ` Patrick McHardy
0 siblings, 1 reply; 3+ messages in thread
From: Ben Greear @ 2009-01-26 17:01 UTC (permalink / raw)
To: Patrick McHardy, NetDev
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
In previous kernels, any kernel module could get access to the
'real-device' and the
VLAN-ID for a particular VLAN. In more recent kernels, the code was
restructured
such that this is hard to do without accessing private .h files for any
module that cannot
use GPL-only symbols.
Attached is a patch to once again allow non-GPL modules the ability to
access the
real-device and VLAN id for VLANs. This patch is against 2.6.29-rc2.
Signed-Off-By: Ben Greear<greearb@candelatech.com>
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
[-- Attachment #2: vlan_export.patch --]
[-- Type: text/x-patch, Size: 652 bytes --]
diff --git a/net/8021q/vlan_core.c b/net/8021q/vlan_core.c
index 6c13239..e9db889 100644
--- a/net/8021q/vlan_core.c
+++ b/net/8021q/vlan_core.c
@@ -62,13 +62,13 @@ struct net_device *vlan_dev_real_dev(const struct net_device *dev)
{
return vlan_dev_info(dev)->real_dev;
}
-EXPORT_SYMBOL_GPL(vlan_dev_real_dev);
+EXPORT_SYMBOL(vlan_dev_real_dev);
u16 vlan_dev_vlan_id(const struct net_device *dev)
{
return vlan_dev_info(dev)->vlan_id;
}
-EXPORT_SYMBOL_GPL(vlan_dev_vlan_id);
+EXPORT_SYMBOL(vlan_dev_vlan_id);
static int vlan_gro_common(struct napi_struct *napi, struct vlan_group *grp,
unsigned int vlan_tci, struct sk_buff *skb)
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: VLAN patch: Export symbols as non GPL symbols.
2009-01-26 17:01 VLAN patch: Export symbols as non GPL symbols Ben Greear
@ 2009-01-26 17:05 ` Patrick McHardy
2009-01-26 20:37 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Patrick McHardy @ 2009-01-26 17:05 UTC (permalink / raw)
To: Ben Greear; +Cc: NetDev
Ben Greear wrote:
> In previous kernels, any kernel module could get access to the
> 'real-device' and the
> VLAN-ID for a particular VLAN. In more recent kernels, the code was
> restructured
> such that this is hard to do without accessing private .h files for any
> module that cannot
> use GPL-only symbols.
>
> Attached is a patch to once again allow non-GPL modules the ability to
> access the
> real-device and VLAN id for VLANs. This patch is against 2.6.29-rc2.
>
> Signed-Off-By: Ben Greear<greearb@candelatech.com>
I added that export after moving the code from a header file, but
there's no reason from my side not to export this to non-GPLed
drivers, using _GPL was merely a habit.
Acked-by: Patrick McHardy <kaber@trash.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: VLAN patch: Export symbols as non GPL symbols.
2009-01-26 17:05 ` Patrick McHardy
@ 2009-01-26 20:37 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2009-01-26 20:37 UTC (permalink / raw)
To: kaber; +Cc: greearb, netdev
From: Patrick McHardy <kaber@trash.net>
Date: Mon, 26 Jan 2009 18:05:53 +0100
> Ben Greear wrote:
> > In previous kernels, any kernel module could get access to the 'real-device' and the
> > VLAN-ID for a particular VLAN. In more recent kernels, the code was restructured
> > such that this is hard to do without accessing private .h files for any module that cannot
> > use GPL-only symbols.
> > Attached is a patch to once again allow non-GPL modules the ability to access the
> > real-device and VLAN id for VLANs. This patch is against 2.6.29-rc2.
> > Signed-Off-By: Ben Greear<greearb@candelatech.com>
>
> I added that export after moving the code from a header file, but
> there's no reason from my side not to export this to non-GPLed
> drivers, using _GPL was merely a habit.
>
> Acked-by: Patrick McHardy <kaber@trash.net>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-01-26 20:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-01-26 17:01 VLAN patch: Export symbols as non GPL symbols Ben Greear
2009-01-26 17:05 ` Patrick McHardy
2009-01-26 20:37 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).