From: David Miller <davem@davemloft.net>
To: shemminger@linux-foundation.org
Cc: adobriyan@gmail.com, jgarzik@pobox.com, netdev@vger.kernel.org
Subject: Re: [PATCH] sky2: fix hard hang with netconsoling and iface going up
Date: Tue, 27 Jan 2009 10:19:03 -0800 (PST) [thread overview]
Message-ID: <20090127.101903.144575010.davem@davemloft.net> (raw)
In-Reply-To: <20090127094928.534ff6f6@extreme>
From: Stephen Hemminger <shemminger@linux-foundation.org>
Date: Tue, 27 Jan 2009 09:49:28 -0800
> Netconsole should be smart enough to not try and print to
> a device that is not marked running.
I think the hardware is marked running.
This is at the beginning of the driver's ->open() method.
The netpoll layer is in fact checking those states:
static void netpoll_send_skb(struct netpoll *np, struct sk_buff *skb)
{
...
if (!npinfo || !netif_running(dev) || !netif_device_present(dev)) {
__kfree_skb(skb);
return;
}
next prev parent reply other threads:[~2009-01-27 18:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 12:01 sky2 vs netconsole hard hang Alexey Dobriyan
2009-01-27 13:27 ` [PATCH] sky2: fix hard hang with netconsoling and iface going up Alexey Dobriyan
2009-01-27 13:35 ` Alexey Dobriyan
2009-01-27 17:49 ` Stephen Hemminger
2009-01-27 18:19 ` David Miller [this message]
2009-01-30 1:00 ` David Miller
2009-01-30 1:09 ` David Miller
2009-01-30 11:59 ` Alexey Dobriyan
2009-01-30 21:45 ` David Miller
2009-01-30 22:01 ` Stephen Hemminger
2009-02-01 22:38 ` Alexey Dobriyan
2009-02-02 18:01 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127.101903.144575010.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).