From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: shemminger@vyatta.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, jeff@garzik.org,
Alexander Duyck <alexander.h.duyck@intel.com>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using it.
Date: Mon, 26 Jan 2009 19:20:28 -0800 [thread overview]
Message-ID: <20090127032028.26631.27015.stgit@lost.foo-projects.org> (raw)
From: Alexander Duyck <alexander.h.duyck@intel.com>
A bug was found in which the memory for the tc_skbedit struct was being
used uninitialized to 0. This patch corrects the issue by using a memset
to 0 out the memory of the structure.
Signed-off-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
tc/m_skbedit.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/tc/m_skbedit.c b/tc/m_skbedit.c
index 55e3f89..0e50fbc 100644
--- a/tc/m_skbedit.c
+++ b/tc/m_skbedit.c
@@ -57,6 +57,8 @@ parse_skbedit(struct action_util *a, int *argc_p, char ***argv_p, int tca_id,
__u16 queue_mapping;
__u32 flags = 0, priority;
+ memset(&sel, 0, sizeof(struct tc_skbedit));
+
if (matches(*argv, "skbedit") != 0)
return -1;
next reply other threads:[~2009-01-27 3:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-27 3:20 Jeff Kirsher [this message]
2009-02-10 1:02 ` [PATCH] iproute2: 0 out memory for tc_skbedit struct prior to using it Jeff Kirsher
2009-02-19 17:00 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090127032028.26631.27015.stgit@lost.foo-projects.org \
--to=jeffrey.t.kirsher@intel.com \
--cc=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).