From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4]: net: Allow RX queue selection to seed TX queue hashing.
Date: Wed, 28 Jan 2009 12:22:31 -0800 (PST) [thread overview]
Message-ID: <20090128.122231.208600152.davem@davemloft.net> (raw)
In-Reply-To: <20090128085358.GA15593@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Wed, 28 Jan 2009 19:53:58 +1100
> So can you think of a scenario where we really need this added
> protection?
No matter what you think about the randomness aspect, our
divide avoidance technique being used here will still
get in the way of the situations you seem to be concerned
about.
We do the jhash et al. magic in order to be able to use a
multiply to get the modulus. So the function computing from
RX to TX queue numbers will never be straightforward.
And since we do need to do the jhash to make that multiply
trick work, the randomness comes essentially for free and
does not make the RX to TX queue relationship any more or
less straightforward.
next prev parent reply other threads:[~2009-01-28 20:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 0:40 [PATCH 1/4]: net: Allow RX queue selection to seed TX queue hashing David Miller
2009-01-28 8:53 ` Herbert Xu
2009-01-28 9:29 ` Eric Dumazet
2009-01-28 20:22 ` David Miller [this message]
2009-01-28 21:31 ` Herbert Xu
2009-01-29 0:40 ` David Miller
2009-01-29 1:34 ` Herbert Xu
2009-01-29 1:45 ` David Miller
2009-01-29 4:41 ` Herbert Xu
2009-01-29 5:01 ` David Miller
2009-01-28 18:50 ` Brandeburg, Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128.122231.208600152.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).