From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH 1/4]: net: Allow RX queue selection to seed TX queue hashing.
Date: Wed, 28 Jan 2009 17:45:22 -0800 (PST) [thread overview]
Message-ID: <20090128.174522.208349319.davem@davemloft.net> (raw)
In-Reply-To: <20090129013403.GA24043@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 29 Jan 2009 12:34:03 +1100
> So having more TX queues than you have cores (or rather caches)
> isn't all that useful since a single core can only do so much (and a
> single piece of wire can only carry so much data, no matter how many
> queues you place in front of it).
This is already proven to be false :-)
Having more TX queues helps a lot. Robert's testing confirms
this even when the number of TX queues exceeds the number of
cores.
When Robert directly maps RX queues to a single TX queue on NIU, we
get drops at the qdisc level during his routing tests. With the TX
queue iterator which causes all of the TX queues to be utilizied there
are no drops.
It would not be one bit surprising to me to see more hardware coming
out with more TX queues than RX queues, for similar reasons. It's a
real situation and we have more proof that it's likely to continue
than not.
> > One way to deal with this is to grab the hash the chip computed.
> > I'm reluctant to advocate this because it's expensive with NIU
> > because I have to start using the larger RX descriptor layout
> > to get at that cookie. (see "rx_pkt_hdr0" vs. "rx_pkt_hdr1" in
> > drivers/net/niu.h)
>
> That's a separate discussion. The hash would be useful for the
> software multiplexer discussed above, and further processing in
> our stack. But it isn't all that important with regards to keeping
> the traffic on the core where it arrived.
I see your point.
next prev parent reply other threads:[~2009-01-29 1:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 0:40 [PATCH 1/4]: net: Allow RX queue selection to seed TX queue hashing David Miller
2009-01-28 8:53 ` Herbert Xu
2009-01-28 9:29 ` Eric Dumazet
2009-01-28 20:22 ` David Miller
2009-01-28 21:31 ` Herbert Xu
2009-01-29 0:40 ` David Miller
2009-01-29 1:34 ` Herbert Xu
2009-01-29 1:45 ` David Miller [this message]
2009-01-29 4:41 ` Herbert Xu
2009-01-29 5:01 ` David Miller
2009-01-28 18:50 ` Brandeburg, Jesse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090128.174522.208349319.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).