From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: Shyam_Iyer@Dell.com, michaelc@cs.wisc.edu,
jesse.brandeburg@intel.com, netdev@vger.kernel.org,
olaf.kirch@oracle.com, tgraf@suug.ch, kkeil@suse.de
Subject: Re: [PANIC] lro + iscsi or lro + skb text search causes panic
Date: Thu, 29 Jan 2009 16:13:13 -0800 (PST) [thread overview]
Message-ID: <20090129.161313.249939766.davem@davemloft.net> (raw)
In-Reply-To: <20090128212526.GA22141@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Thu, 29 Jan 2009 08:25:26 +1100
> On Wed, Jan 28, 2009 at 05:47:57PM +0530, Shyam_Iyer@Dell.com wrote:
> >
> > --- skbuff.c.orig 2009-01-29 01:12:03.000000000 +0530
> > +++ skbuff.c 2009-01-29 01:34:57.000000000 +0530
> > @@ -2039,15 +2039,15 @@
> > st->frag_data = NULL;
> > }
> >
> > - if (st->cur_skb->next) {
> > - st->cur_skb = st->cur_skb->next;
> > - st->frag_idx = 0;
> > - goto next_skb;
> > - } else if (st->root_skb == st->cur_skb &&
> > + if (st->root_skb == st->cur_skb &&
> > skb_shinfo(st->root_skb)->frag_list) {
> > st->cur_skb = skb_shinfo(st->root_skb)->frag_list;
> > st->frag_idx=0;
> > goto next_skb;
> > + } else if (st->cur_skb->next) {
> > + st->cur_skb = st->cur_skb->next;
> > + st->frag_idx = 0;
> > + goto next_skb;
> > }
> >
> > return 0;
>
> Good catch!
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Excellent work everyone. I applied both Herbert's and
Shyam's patches, and will queue them up for -stable as well.
Thanks again.
next prev parent reply other threads:[~2009-01-30 0:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 20:55 [PANIC] lro + iscsi or lro + skb text search causes panic Brandeburg, Jesse
2009-01-22 22:49 ` Mike Christie
2009-01-23 4:22 ` Mike Christie
2009-01-23 4:29 ` Mike Christie
2009-01-26 5:34 ` David Miller
2009-01-22 23:21 ` Herbert Xu
2009-01-22 23:45 ` Brandeburg, Jesse
2009-01-23 0:04 ` Mike Christie
2009-01-26 5:32 ` David Miller
2009-01-26 22:30 ` Herbert Xu
2009-01-27 1:40 ` Brandeburg, Jesse
2009-01-27 3:01 ` Herbert Xu
2009-01-27 5:52 ` David Miller
2009-01-27 6:12 ` Mike Christie
[not found] ` <46A00B48CC54E4468EF6911F877AC4CA01EF2BC9@blrx3m10.blr.amer.dell.com>
2009-01-28 21:25 ` Herbert Xu
2009-01-30 0:13 ` David Miller [this message]
2009-01-26 20:54 ` Mike Christie
-- strict thread matches above, loose matches on Subject: below --
2009-01-28 12:36 Shyam_Iyer
2009-01-28 18:22 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129.161313.249939766.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Shyam_Iyer@Dell.com \
--cc=herbert@gondor.apana.org.au \
--cc=jesse.brandeburg@intel.com \
--cc=kkeil@suse.de \
--cc=michaelc@cs.wisc.edu \
--cc=netdev@vger.kernel.org \
--cc=olaf.kirch@oracle.com \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).