From: David Miller <davem@davemloft.net>
To: steve.glendinning@smsc.com
Cc: netdev@vger.kernel.org, ian.saturley@smsc.com
Subject: Re: [PATCH 1/1] smsc9420: fix interrupt signalling test failures
Date: Thu, 29 Jan 2009 17:29:23 -0800 (PST) [thread overview]
Message-ID: <20090129.172923.24519684.davem@davemloft.net> (raw)
In-Reply-To: <1233247163-4317-2-git-send-email-steve.glendinning@smsc.com>
From: Steve Glendinning <steve.glendinning@smsc.com>
Date: Thu, 29 Jan 2009 16:39:23 +0000
> smsc9420 performs an interrupt signalling test when the interface is
> brought up. The current code mistakenly sets its test flag to false
> AFTER enabling the software interrupt source, making failure quite
> likely.
>
> This patch changes the code to set the test flag BEFORE enabling
> interrupts. I've also removed an smp_wmb because the following spinlock
> provides an implicit memory barrier.
>
> Signed-off-by: Steve Glendinning <steve.glendinning@smsc.com>
Applied, thanks Steve.
prev parent reply other threads:[~2009-01-30 1:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 16:39 [PATCH 0/1] smsc9420: fix interrupt signalling test failures Steve Glendinning
2009-01-29 16:39 ` [PATCH 1/1] " Steve Glendinning
2009-01-30 1:29 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090129.172923.24519684.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=ian.saturley@smsc.com \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).