From: Rusty Russell <rusty@rustcorp.com.au>
To: Alex Williamson <alex.williamson@hp.com>
Cc: markmc@redhat.com, netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering
Date: Fri, 30 Jan 2009 15:33:51 +1030 [thread overview]
Message-ID: <200901301533.52115.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090129230502.2672.87669.stgit@debian.lart>
On Friday 30 January 2009 09:35:02 Alex Williamson wrote:
> I'm not completely sure it's everything
> you're looking for Rusty, but it does seem cleaner. Let me know if
> this is closer to what you're thinking.
Yep, now I'll go through the patches more carefully.
I know it's a pain to get this kind of nit-picking feedback, but it's an ordeal I force on everyone the first time they make a major contribution; it ensures the code "feels" consistent and means that when I read the code in future I'm not surprised by things which aren't *quite* how I expect.
Note that I tend to comment on *everything* where I would have done it differently. So I expect you to argue at least half of them.
Thanks!
Rusty.
next prev parent reply other threads:[~2009-01-30 5:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 23:05 [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering Alex Williamson
2009-01-29 23:05 ` [PATCH v2 1/4] virtio_net: Add a virtqueue for outbound control commands Alex Williamson
2009-01-30 5:08 ` Rusty Russell
2009-01-29 23:05 ` [PATCH v2 2/4] virtio_net: Add a set_rx_mode interface Alex Williamson
2009-01-30 5:30 ` Rusty Russell
2009-01-29 23:05 ` [PATCH v2 3/4] virtio_net: Add a MAC filter table Alex Williamson
2009-01-30 5:46 ` Rusty Russell
2009-01-29 23:05 ` [PATCH v2 4/4] virtio_net: Add support for VLAN filtering in the hypervisor Alex Williamson
2009-01-30 6:01 ` Rusty Russell
2009-01-30 1:49 ` [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering David Miller
2009-01-30 7:05 ` Rusty Russell
2009-01-30 7:12 ` David Miller
2009-01-30 5:03 ` Rusty Russell [this message]
2009-02-01 20:05 ` [PATCH v3 " Alex Williamson
2009-02-01 20:05 ` [PATCH v3 1/4] virtio_net: Add a virtqueue for outbound control commands Alex Williamson
2009-02-02 9:40 ` Rusty Russell
2009-02-02 14:10 ` Anthony Liguori
2009-02-01 20:05 ` [PATCH v3 2/4] virtio_net: Add a set_rx_mode interface Alex Williamson
2009-02-02 9:52 ` Rusty Russell
2009-02-02 21:34 ` Alex Williamson
2009-02-03 2:54 ` Rusty Russell
2009-02-01 20:05 ` [PATCH v3 3/4] virtio_net: Add a MAC filter table Alex Williamson
2009-02-02 9:57 ` Rusty Russell
2009-02-01 20:05 ` [PATCH v3 4/4] virtio_net: Add support for VLAN filtering in the hypervisor Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901301533.52115.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=alex.williamson@hp.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).