From: Rusty Russell <rusty@rustcorp.com.au>
To: David Stevens <dlstevens@us.ibm.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
Alex Williamson <alex.williamson@hp.com>,
kvm@vger.kernel.org, markmc@redhat.com, netdev@vger.kernel.org,
netdev-owner@vger.kernel.org
Subject: Re: [PATCH 4/5] virtio_net: Add a MAC filter table
Date: Fri, 30 Jan 2009 17:33:24 +1030 [thread overview]
Message-ID: <200901301733.25136.rusty@rustcorp.com.au> (raw)
In-Reply-To: <OF025C8F2F.2E8FFF17-ON8825754D.0020EE83-8825754D.002299DE@us.ibm.com>
On Thursday 29 January 2009 16:47:55 David Stevens wrote:
> Also, if you can't keep all the MAC multicast addresses (ie,
> the limit is memory and not look-up speed), then getting
> out of multicast-promiscuous mode correctly isn't easy
> since you don't know what groups you "forgot". You could
> rebuild from the protocol memberships, if you know when
> you've left enough groups to fit, but otherwise the MAC
> multicast addresses you didn't keep of course won't work if you
> leave multicast-promiscuous mode and the filter doesn't
> have them.
The command is simply "set the filter", not "add" and "delete", so the host doesn't have this problem.
VLAN has more of an issue: that has add and del. So the host can do a counting hash, or say remember 16 and then a count of overflows, but both will be suboptimal over time.
Cheers,
Rusty.
next prev parent reply other threads:[~2009-01-30 7:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-16 21:13 [PATCH 0/5] virtio_net: Add MAC and VLAN filtering Alex Williamson
2009-01-16 21:13 ` [PATCH 1/5] virtio_net: Allow setting the MAC address of the NIC Alex Williamson
2009-01-19 9:32 ` Mark McLoughlin
2009-01-16 21:13 ` [PATCH 2/5] virtio_net: Add a virtqueue for outbound control commands Alex Williamson
2009-01-19 9:32 ` Mark McLoughlin
[not found] ` <200901271352.57887.rusty@rustcorp.com.au>
2009-01-27 4:00 ` Alex Williamson
2009-01-28 13:05 ` Rusty Russell
2009-01-28 19:02 ` Alex Williamson
2009-01-29 1:35 ` Rusty Russell
2009-01-16 21:13 ` [PATCH 3/5] virtio_net: Add a set_rx_mode interface Alex Williamson
2009-01-19 9:32 ` Mark McLoughlin
2009-01-16 21:13 ` [PATCH 4/5] virtio_net: Add a MAC filter table Alex Williamson
2009-01-19 9:33 ` Mark McLoughlin
[not found] ` <200901271300.30330.rusty@rustcorp.com.au>
2009-01-27 3:38 ` Alex Williamson
2009-01-28 10:45 ` Rusty Russell
2009-01-28 17:48 ` Alex Williamson
2009-01-28 23:55 ` Rusty Russell
2009-01-29 0:34 ` Herbert Xu
2009-01-29 6:17 ` David Stevens
2009-01-30 7:03 ` Rusty Russell [this message]
2009-01-16 21:13 ` [PATCH 5/5] virtio_net: Add support for VLAN filtering in the hypervisor Alex Williamson
2009-01-19 9:32 ` Mark McLoughlin
2009-01-20 16:36 ` Alex Williamson
2009-01-20 16:44 ` Mark McLoughlin
2009-01-26 2:08 ` David Miller
2009-01-26 17:42 ` Alex Williamson
[not found] ` <200901271422.33369.rusty@rustcorp.com.au>
2009-01-27 4:19 ` Alex Williamson
2009-01-19 6:05 ` [PATCH 0/5] virtio_net: Add MAC and VLAN filtering David Miller
2009-01-19 8:30 ` Mark McLoughlin
2009-01-20 1:10 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901301733.25136.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=alex.williamson@hp.com \
--cc=dlstevens@us.ibm.com \
--cc=herbert@gondor.apana.org.au \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=netdev-owner@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).