From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Matt Carlson" Subject: Re: 2.6.29-rc3: tg3 dead after resume Date: Fri, 30 Jan 2009 10:40:30 -0800 Message-ID: <20090130184030.GA14933@xw6200.broadcom.net> References: <20090129184215.GA13459@xw6200.broadcom.net> <20090129222247.GA13861@xw6200.broadcom.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: "Matthew Carlson" , "Linus Torvalds" , "netdev@vger.kernel.org" , "Linux Kernel Mailing List" , "David S. Miller" , "Andrew Morton" To: "Parag Warudkar" Return-path: In-Reply-To: Content-Disposition: inline Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Thu, Jan 29, 2009 at 02:35:44PM -0800, Parag Warudkar wrote: > > > On Thu, 29 Jan 2009, Matt Carlson wrote: > > > FWIW, I can suspend and resume using the latest linux-2.6 kernel > > on a machine with a similar chip here. The problem doesn't seem to > > affect all Broadcom devices. > > It is failing for me on HP xw6600 workstation, if that helps in any way. > > Parag O.K. Let's test some more assumptions. Can you apply the following patch and observe the system logs when the device is first loaded and again after resume. The patch looks at the pci command register to verify that memory space IO is indeed enabled. (It should be.) This is all that should be needed for MMIO to work. If the PCI_COMMAND message doesn't match, then it means that the PCI_COMMAND register isn't getting restored for some reason. If they do match, then something else in the system is not getting restored correctly. diff --git a/drivers/net/tg3.c b/drivers/net/tg3.c index 8b3f846..67bb29f 100644 --- a/drivers/net/tg3.c +++ b/drivers/net/tg3.c @@ -7225,8 +7225,17 @@ static int tg3_reset_hw(struct tg3 *tp, int reset_phy) */ static int tg3_init_hw(struct tg3 *tp, int reset_phy) { + u16 cmd; + tg3_switch_clocks(tp); + pci_read_config_word(tp->pdev, PCI_COMMAND, &cmd); + + printk(KERN_NOTICE "%s: PCI_COMMAND reg = 0x%x (bit 1 is %s)\n", + tp->dev->name, cmd, (cmd & PCI_COMMAND_MEMORY) ? "on" : "off"); + printk(KERN_NOTICE "%s: Reg value at offset 0x0 is 0x%x\n", + tp->dev->name, tr32(0x0)); + tw32(TG3PCI_MEM_WIN_BASE_ADDR, 0); return tg3_reset_hw(tp, reset_phy);