From: Ingo Molnar <mingo@elte.hu>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Parag Warudkar <parag.lkml@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matt Carlson <mcarlson@broadcom.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: 2.6.29-rc3: tg3 dead after resume
Date: Sat, 31 Jan 2009 01:44:16 +0100 [thread overview]
Message-ID: <20090131004416.GC13709@elte.hu> (raw)
In-Reply-To: <200901310138.51214.rjw@sisk.pl>
* Rafael J. Wysocki <rjw@sisk.pl> wrote:
> +static struct dev_pm_ops pcie_portdrv_pm_ops = {
> + .suspend = pcie_port_device_suspend,
> + .resume = pcie_port_device_resume,
> + .freeze = pcie_port_device_suspend,
> + .thaw = pcie_port_device_resume,
> + .poweroff = pcie_port_device_suspend,
> + .restore = pcie_port_device_resume,
> +};
pet peeve: could we please use vertical spaces wherever they improve the
code?
Something like:
static struct dev_pm_ops pcie_portdrv_pm_ops = {
.suspend = pcie_port_device_suspend,
.resume = pcie_port_device_resume,
.freeze = pcie_port_device_suspend,
.thaw = pcie_port_device_resume,
.poweroff = pcie_port_device_suspend,
.restore = pcie_port_device_resume,
};
... and it all becomes clear at a glance. Please?
Ingo
next prev parent reply other threads:[~2009-01-31 0:44 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 0:14 2.6.29-rc3: tg3 dead after resume Parag Warudkar
2009-01-29 1:09 ` Linus Torvalds
2009-01-29 1:49 ` Parag Warudkar
2009-01-29 2:10 ` Linus Torvalds
2009-01-29 2:19 ` Matt Carlson
2009-01-29 22:22 ` Rafael J. Wysocki
2009-01-29 18:42 ` Matt Carlson
2009-01-29 22:06 ` Parag Warudkar
2009-01-29 22:22 ` Matt Carlson
2009-01-29 22:35 ` Parag Warudkar
2009-01-29 23:10 ` Rafael J. Wysocki
2009-01-30 18:40 ` Matt Carlson
2009-01-30 22:50 ` Parag Warudkar
2009-01-30 23:06 ` Linus Torvalds
2009-01-30 23:33 ` Linus Torvalds
2009-01-30 23:45 ` Parag Warudkar
2009-01-30 23:57 ` Linus Torvalds
2009-01-30 23:59 ` Rafael J. Wysocki
2009-01-31 0:28 ` Parag Warudkar
2009-01-31 0:38 ` Rafael J. Wysocki
2009-01-31 0:44 ` Ingo Molnar [this message]
2009-01-31 0:47 ` Rafael J. Wysocki
2009-01-31 1:21 ` Parag Warudkar
2009-01-31 1:37 ` Rafael J. Wysocki
2009-01-31 1:42 ` Parag Warudkar
2009-02-03 9:29 ` Rafael J. Wysocki
2009-02-03 21:27 ` Parag Warudkar
2009-02-03 22:15 ` Rafael J. Wysocki
2009-02-04 0:38 ` Parag Warudkar
2009-02-04 0:41 ` Rafael J. Wysocki
2009-02-07 3:00 ` Linus Torvalds
2009-02-07 18:03 ` Jesse Barnes
2009-01-31 1:46 ` Linus Torvalds
2009-01-31 1:54 ` Parag Warudkar
2009-01-31 2:25 ` Linus Torvalds
2009-01-31 2:40 ` Parag Warudkar
2009-01-31 18:51 ` Rafael J. Wysocki
2009-01-31 2:19 ` Linus Torvalds
2009-01-31 20:45 ` Rafael J. Wysocki
2009-01-31 1:41 ` Linus Torvalds
2009-01-31 21:08 ` Rafael J. Wysocki
2009-01-31 21:42 ` What should PCI core do during suspend-resume? (was: Re: 2.6.29-rc3: tg3 dead after resume) Rafael J. Wysocki
2009-01-31 21:59 ` Linus Torvalds
2009-01-31 23:08 ` Rafael J. Wysocki
2009-01-31 23:27 ` Linus Torvalds
2009-01-31 23:39 ` Linus Torvalds
2009-02-01 0:36 ` Rafael J. Wysocki
2009-02-01 1:06 ` Linus Torvalds
2009-02-01 1:13 ` Linus Torvalds
2009-02-01 1:20 ` Arjan van de Ven
2009-02-01 1:24 ` Rafael J. Wysocki
2009-02-07 9:21 ` Pavel Machek
2009-01-31 21:47 ` 2.6.29-rc3: tg3 dead after resume Linus Torvalds
2009-01-31 22:46 ` Rafael J. Wysocki
2009-01-31 23:01 ` Linus Torvalds
2009-02-01 0:11 ` Rafael J. Wysocki
2009-02-01 0:32 ` Linus Torvalds
2009-02-01 0:41 ` Rafael J. Wysocki
2009-02-01 0:51 ` Linus Torvalds
2009-02-07 3:27 ` Benjamin Herrenschmidt
2009-02-07 3:26 ` Benjamin Herrenschmidt
2009-01-29 23:03 ` Rafael J. Wysocki
2009-01-29 23:41 ` Matt Carlson
2009-01-30 0:10 ` Rafael J. Wysocki
2009-01-30 22:31 ` Parag Warudkar
2009-01-30 22:36 ` Linus Torvalds
2009-01-30 22:54 ` Rafael J. Wysocki
2009-01-30 23:07 ` Linus Torvalds
2009-01-30 23:13 ` Parag Warudkar
2009-01-30 23:31 ` Rafael J. Wysocki
2009-01-30 23:51 ` Linus Torvalds
2009-01-31 0:07 ` Rafael J. Wysocki
2009-01-31 0:34 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090131004416.GC13709@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mcarlson@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=parag.lkml@gmail.com \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).