From: David Miller <davem@davemloft.net>
To: dwalker@fifo99.com
Cc: roel.kluin@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: variables reach -1, but 0 tested
Date: Sun, 01 Feb 2009 01:58:05 -0800 (PST) [thread overview]
Message-ID: <20090201.015805.28182673.davem@davemloft.net> (raw)
In-Reply-To: <1233434112.5903.28.camel@desktop>
From: Daniel Walker <dwalker@fifo99.com>
Date: Sat, 31 Jan 2009 12:35:12 -0800
> On Sat, 2009-01-31 at 11:36 +0100, Roel Kluin wrote:
>
> >
> > - while (limit--) {
> > + while (--limit) {
> > val = phy_read(phy, MII_BMCR);
> > if (val >= 0 && (val & BMCR_RESET) == 0)
> > break;
>
> It looks like these are checked for <= to 0 , are these changes strictly
> nessesary?
Agreed.
I'd like to apply these fixes to net-2.6 but I can't if there
are spurious cases in here.
I'm dropping this patch for now.
next prev parent reply other threads:[~2009-02-01 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 10:36 [PATCH] net: variables reach -1, but 0 tested Roel Kluin
2009-01-31 20:35 ` Daniel Walker
2009-02-01 9:58 ` David Miller [this message]
2009-02-01 16:23 ` Roel Kluin
2009-02-03 7:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090201.015805.28182673.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dwalker@fifo99.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).