* [PATCH] udp : increments sk_drops in __udp_queue_rcv_skb()
@ 2009-02-02 15:32 Eric Dumazet
2009-02-02 21:42 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Eric Dumazet @ 2009-02-02 15:32 UTC (permalink / raw)
To: David S. Miller; +Cc: Linux Netdev List, Herbert Xu
Hi David
While investigating with Kenny Chang multicast drops problems, I found sk_drops
field was not anymore updated in current kernels for UDP IPV4 sockets.
Thank you
[PATCH] udp: increments sk_drops in __udp_queue_rcv_skb()
Commit 93821778def10ec1e69aa3ac10adee975dad4ff3
(udp: Fix rcv socket locking) accidentally removed sk_drops increments for
UDP IPV4 sockets.
This field can be used to detect incorrect sizing of socket receive buffers.
Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
---
diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c
index b7faffe..997c418 100644
--- a/net/ipv4/udp.c
+++ b/net/ipv4/udp.c
@@ -1015,9 +1015,11 @@ static int __udp_queue_rcv_skb(struct sock *sk, struct sk_buff *skb)
if ((rc = sock_queue_rcv_skb(sk, skb)) < 0) {
/* Note that an ENOMEM error is charged twice */
- if (rc == -ENOMEM)
+ if (rc == -ENOMEM) {
UDP_INC_STATS_BH(sock_net(sk), UDP_MIB_RCVBUFERRORS,
is_udplite);
+ atomic_inc(&sk->sk_drops);
+ }
goto drop;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] udp : increments sk_drops in __udp_queue_rcv_skb()
2009-02-02 15:32 [PATCH] udp : increments sk_drops in __udp_queue_rcv_skb() Eric Dumazet
@ 2009-02-02 21:42 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2009-02-02 21:42 UTC (permalink / raw)
To: dada1; +Cc: netdev, herbert
From: Eric Dumazet <dada1@cosmosbay.com>
Date: Mon, 02 Feb 2009 16:32:51 +0100
> udp: increments sk_drops in __udp_queue_rcv_skb()
>
> Commit 93821778def10ec1e69aa3ac10adee975dad4ff3
> (udp: Fix rcv socket locking) accidentally removed sk_drops increments for
> UDP IPV4 sockets.
>
> This field can be used to detect incorrect sizing of socket receive buffers.
>
> Signed-off-by: Eric Dumazet <dada1@cosmosbay.com>
Yikes, good catch Eric.
Applied and queued up for -stable.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-02-02 21:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-02-02 15:32 [PATCH] udp : increments sk_drops in __udp_queue_rcv_skb() Eric Dumazet
2009-02-02 21:42 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).