From: David Miller <davem@davemloft.net>
To: roel.kluin@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sungem: limit reaches -1, but 0 tested
Date: Mon, 02 Feb 2009 23:19:59 -0800 (PST) [thread overview]
Message-ID: <20090202.231959.127283027.davem@davemloft.net> (raw)
In-Reply-To: <4985D8AF.1040009@gmail.com>
From: Roel Kluin <roel.kluin@gmail.com>
Date: Sun, 01 Feb 2009 18:15:27 +0100
> while (limit--)
> if (test())
> break;
>
> if (limit <= 0)
> goto test_failed;
>
> In the last iteration, limit is decremented after the test to 0.
> If just thereafter test() succeeds and a break occurs, the goto
> still occurs because limit is 0.
>
> Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Also applied, thanks.
prev parent reply other threads:[~2009-02-03 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-31 12:42 [PATCH] sungem: limit reaches -1, but 0 tested Roel Kluin
2009-02-01 9:59 ` David Miller
2009-02-01 17:15 ` Roel Kluin
2009-02-03 7:19 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090202.231959.127283027.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roel.kluin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).