From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Denys Fedoryschenko <denys@visp.net.lb>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers
Date: Mon, 2 Feb 2009 10:07:42 -0800 [thread overview]
Message-ID: <20090202100742.690e0c8d@extreme> (raw)
In-Reply-To: <200902021926.17768.denys@visp.net.lb>
On Mon, 2 Feb 2009 19:26:17 +0200
Denys Fedoryschenko <denys@visp.net.lb> wrote:
> ------------->
> iproute2 : invalid burst/cburst calculation with hrtimers
>
> If hrtimers on, /proc/net/psched shows 4th variable
> as 1000000000
> Because burst calculated by division rate to this variable,
> it will be almost always zero. As result, we will get higher system
> load on low rates, and on high rates shaper will not able to process
> data. So it is kind of critical bugfix for systems with hrtimers.
> It is checked and proved. Core 2 Quad was not able to
> shape 200Mbps, and gave only 180-190. It is more safe to set it
> to 1000HZ. If user wants, he can set custom "env" HZ variable.
>
> Signed-off-by: Denys Fedoryschenko <denys@visp.net.lb>
> ---
>
> -------------------------------------------------------
I would rather this be converted to floating point.
next prev parent reply other threads:[~2009-02-02 18:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-02 17:26 [PATCH] [RESEND] iproute2 : invalid burst/cburst calculation with hrtimers Denys Fedoryschenko
2009-02-02 18:07 ` Stephen Hemminger [this message]
2009-02-02 18:21 ` Denys Fedoryschenko
2009-02-04 21:20 ` Jarek Poplawski
2009-02-04 21:53 ` Jarek Poplawski
2009-02-04 22:26 ` Denys Fedoryschenko
2009-02-04 22:49 ` Jarek Poplawski
2009-02-04 23:24 ` Denys Fedoryschenko
2009-02-05 7:38 ` Jarek Poplawski
2009-02-05 9:01 ` Denys Fedoryschenko
2009-02-05 10:08 ` Jarek Poplawski
2009-02-05 11:09 ` Denys Fedoryschenko
2009-02-05 11:56 ` Jarek Poplawski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090202100742.690e0c8d@extreme \
--to=shemminger@linux-foundation.org \
--cc=denys@visp.net.lb \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).