From: Rusty Russell <rusty@rustcorp.com.au>
To: Alex Williamson <alex.williamson@hp.com>
Cc: markmc@redhat.com, netdev@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3 3/4] virtio_net: Add a MAC filter table
Date: Mon, 2 Feb 2009 20:27:14 +1030 [thread overview]
Message-ID: <200902022027.14581.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20090201200520.8183.3168.stgit@debian.lart>
On Monday 02 February 2009 06:35:20 Alex Williamson wrote:
> + * In addition to the class/cmd header, the TABLE_SET command requires
> + * two out scatterlists. Each contains a 4 byte count of entries followed
> + * by a concatenated byte stream of the ETH_ALEN MAC addresses. The
> + * first sg list contains unicast addresses, the second is for multicast.
> + * This functionality is present if the VIRTIO_NET_F_CTRL_RX feature
> + * is available.
> + */
> +struct virtio_net_ctrl_mac {
> + __u32 entries;
> + __u8 macs[];
> +} __attribute__((packed));
Hmm, can we make this more explicit? eg.
struct virtio_net_ctrl_mac {
__u32 unicast_entries, multicast_entriues;
__u8 macs[ETH_ALEN][];
} __attribute__((packed));
Might simplify the code a tiny bit, too...
Thanks,
Rusty.
next prev parent reply other threads:[~2009-02-02 9:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 23:05 [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering Alex Williamson
2009-01-29 23:05 ` [PATCH v2 1/4] virtio_net: Add a virtqueue for outbound control commands Alex Williamson
2009-01-30 5:08 ` Rusty Russell
2009-01-29 23:05 ` [PATCH v2 2/4] virtio_net: Add a set_rx_mode interface Alex Williamson
2009-01-30 5:30 ` Rusty Russell
2009-01-29 23:05 ` [PATCH v2 3/4] virtio_net: Add a MAC filter table Alex Williamson
2009-01-30 5:46 ` Rusty Russell
2009-01-29 23:05 ` [PATCH v2 4/4] virtio_net: Add support for VLAN filtering in the hypervisor Alex Williamson
2009-01-30 6:01 ` Rusty Russell
2009-01-30 1:49 ` [PATCH v2 0/4] virtio_net: Add MAC and VLAN filtering David Miller
2009-01-30 7:05 ` Rusty Russell
2009-01-30 7:12 ` David Miller
2009-01-30 5:03 ` Rusty Russell
2009-02-01 20:05 ` [PATCH v3 " Alex Williamson
2009-02-01 20:05 ` [PATCH v3 1/4] virtio_net: Add a virtqueue for outbound control commands Alex Williamson
2009-02-02 9:40 ` Rusty Russell
2009-02-02 14:10 ` Anthony Liguori
2009-02-01 20:05 ` [PATCH v3 2/4] virtio_net: Add a set_rx_mode interface Alex Williamson
2009-02-02 9:52 ` Rusty Russell
2009-02-02 21:34 ` Alex Williamson
2009-02-03 2:54 ` Rusty Russell
2009-02-01 20:05 ` [PATCH v3 3/4] virtio_net: Add a MAC filter table Alex Williamson
2009-02-02 9:57 ` Rusty Russell [this message]
2009-02-01 20:05 ` [PATCH v3 4/4] virtio_net: Add support for VLAN filtering in the hypervisor Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902022027.14581.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=alex.williamson@hp.com \
--cc=kvm@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).