From: Stephen Hemminger <shemminger@vyatta.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: [PATCH 1/4] sky2: remove unneede workaround
Date: Tue, 03 Feb 2009 13:27:27 -0800 [thread overview]
Message-ID: <20090203212755.892910982@vyatta.com> (raw)
In-Reply-To: 20090203212726.983207890@vyatta.com
[-- Attachment #1: sky2-tim-opt.patch --]
[-- Type: text/plain, Size: 813 bytes --]
This workaround is not needed. It was inherited from sk98lin driver but only
applies to an early development version of the chip that is not supported
by sky2. The workaround required an unnecessary pci read which hurts performance
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
--- a/drivers/net/sky2.c 2009-01-26 17:23:25.869792360 -0800
+++ b/drivers/net/sky2.c 2009-01-27 09:43:21.770394724 -0800
@@ -2687,13 +2687,6 @@ static int sky2_poll(struct napi_struct
goto done;
}
- /* Bug/Errata workaround?
- * Need to kick the TX irq moderation timer.
- */
- if (sky2_read8(hw, STAT_TX_TIMER_CTRL) == TIM_START) {
- sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_STOP);
- sky2_write8(hw, STAT_TX_TIMER_CTRL, TIM_START);
- }
napi_complete(napi);
sky2_read32(hw, B0_Y2_SP_LISR);
done:
--
next prev parent reply other threads:[~2009-02-03 21:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 21:27 [PATCH 0/4] Sky2 update Stephen Hemminger
2009-02-03 21:27 ` Stephen Hemminger [this message]
2009-02-03 21:27 ` [PATCH 2/4] sky2: handle dma mapping errors Stephen Hemminger
2009-02-03 21:27 ` [PATCH 3/4] sky2: move VPD display into debug interface Stephen Hemminger
2009-02-03 21:27 ` [PATCH 4/4] sky2: set VPD size Stephen Hemminger
2009-02-03 23:09 ` [PATCH 0/4] Sky2 update David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090203212755.892910982@vyatta.com \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).