[net-next PATCH] e1000e: normalize usage of serdes_has_link

[net-next PATCH] e1000e: normalize usage of serdes_has_link

[Alex Chiang]

Cosmetic change to use struct e1000_mac_info.serdes_has_link
consistently as the 'bool' that it's declared as.

No functional change.

Signed-off-by: Alex Chiang <achiang@hp.com>
---

 ethtool.c |    2 +-
 lib.c     |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/e1000e/ethtool.c b/drivers/net/e1000e/ethtool.c
index e48956d..2557aee 100644
--- a/drivers/net/e1000e/ethtool.c
+++ b/drivers/net/e1000e/ethtool.c
@@ -1589,7 +1589,7 @@ static int e1000_link_test(struct e1000_adapter *adapter, u64 *data)
 	*data = 0;
 	if (hw->phy.media_type == e1000_media_type_internal_serdes) {
 		int i = 0;
-		hw->mac.serdes_has_link = 0;
+		hw->mac.serdes_has_link = false;
 
 		/*
 		 * On some blade server designs, link establishment
diff --git a/drivers/net/e1000e/lib.c b/drivers/net/e1000e/lib.c
index 6674110..ac2f34e 100644
--- a/drivers/net/e1000e/lib.c
+++ b/drivers/net/e1000e/lib.c
@@ -501,7 +501,7 @@ s32 e1000e_check_for_fiber_link(struct e1000_hw *hw)
 		ew32(TXCW, mac->txcw);
 		ew32(CTRL, (ctrl & ~E1000_CTRL_SLU));
 
-		mac->serdes_has_link = 1;
+		mac->serdes_has_link = true;
 	}
 
 	return 0;
@@ -566,7 +566,7 @@ s32 e1000e_check_for_serdes_link(struct e1000_hw *hw)
 		ew32(TXCW, mac->txcw);
 		ew32(CTRL, (ctrl & ~E1000_CTRL_SLU));
 
-		mac->serdes_has_link = 1;
+		mac->serdes_has_link = true;
 	} else if (!(E1000_TXCW_ANE & er32(TXCW))) {
 		/*
 		 * If we force link for non-auto-negotiation switch, check

RE: [net-next PATCH] e1000e: normalize usage of serdes_has_link

[Kirsher, Jeffrey T]

>-----Original Message-----
>From: Alex Chiang [mailto:achiang@hp.com]
>Sent: Wednesday, February 04, 2009 2:05 PM
>To: davem@davemloft.net
>Cc: Kirsher, Jeffrey T; jeff@garzik.org; Brandeburg, Jesse; Allan, Bruce W;
>netdev@vger.kernel.org
>Subject: [net-next PATCH] e1000e: normalize usage of serdes_has_link
>
>Cosmetic change to use struct e1000_mac_info.serdes_has_link
>consistently as the 'bool' that it's declared as.
>
>No functional change.
>
>Signed-off-by: Alex Chiang <achiang@hp.com>

Acked-by: Jeff Kirsher <Jeffrey.t.kirsher@intel.com>

Cheers,
Jeff

Re: [net-next PATCH] e1000e: normalize usage of serdes_has_link

[David Miller]

From: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>
Date: Wed, 4 Feb 2009 17:23:18 -0800

> >-----Original Message-----
> >From: Alex Chiang [mailto:achiang@hp.com]
> >Sent: Wednesday, February 04, 2009 2:05 PM
> >To: davem@davemloft.net
> >Cc: Kirsher, Jeffrey T; jeff@garzik.org; Brandeburg, Jesse; Allan, Bruce W;
> >netdev@vger.kernel.org
> >Subject: [net-next PATCH] e1000e: normalize usage of serdes_has_link
> >
> >Cosmetic change to use struct e1000_mac_info.serdes_has_link
> >consistently as the 'bool' that it's declared as.
> >
> >No functional change.
> >
> >Signed-off-by: Alex Chiang <achiang@hp.com>
> 
> Acked-by: Jeff Kirsher <Jeffrey.t.kirsher@intel.com>

Applied, thanks.