From: David Miller <davem@davemloft.net>
To: jdb@comx.dk
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] Fix UDP short packet false positive
Date: Thu, 05 Feb 2009 15:06:12 -0800 (PST) [thread overview]
Message-ID: <20090205.150612.208352009.davem@davemloft.net> (raw)
In-Reply-To: <1233838027.20497.132.camel@localhost.localdomain>
From: Jesper Dangaard Brouer <jdb@comx.dk>
Date: Thu, 05 Feb 2009 13:47:07 +0100
>
> The UDP header pointer assignment must happen after calling
> pskb_may_pull(). As pskb_may_pull() can potentially alter the SKB
> buffer.
>
> This was exposted by running multicast traffic through the NIU driver,
> as it won't prepull the protocol headers into the linear area on
> receive.
>
> Signed-off-by: Jesper Dangaard Brouer <hawk@comx.dk>
Excellent work!
Applied and queued up for -stable, thanks!
next prev parent reply other threads:[~2009-02-05 23:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-03 13:38 BUG: NIU driver: strange issues with multicast "UDP: short packet" Jesper Dangaard Brouer
2009-02-03 23:38 ` David Miller
2009-02-04 8:55 ` Jesper Dangaard Brouer
2009-02-04 9:00 ` David Miller
2009-02-04 9:32 ` Jesper Dangaard Brouer
2009-02-04 9:34 ` David Miller
2009-02-05 12:44 ` Jesper Dangaard Brouer
2009-02-05 12:47 ` [PATCH] Fix UDP short packet false positive Jesper Dangaard Brouer
2009-02-05 23:06 ` David Miller [this message]
2009-02-06 9:00 ` [RFC] " Jesper Dangaard Brouer
2009-02-06 9:08 ` David Miller
2009-02-06 9:55 ` [PATCH] udp: Fix potential wrong ip_hdr(skb) pointers Jesper Dangaard Brouer
2009-02-06 9:59 ` David Miller
2009-02-06 10:04 ` Eric Dumazet
2009-02-06 10:49 ` Jesper Dangaard Brouer
2009-02-06 11:11 ` David Miller
2009-02-04 11:52 ` BUG: NIU driver: strange issues with multicast "UDP: short packet" Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205.150612.208352009.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jdb@comx.dk \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).