From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com,
emil.s.tantilov@intel.com
Subject: Re: gro: Fix frag_list merging on imprecisely split packets
Date: Thu, 05 Feb 2009 21:27:08 -0800 (PST) [thread overview]
Message-ID: <20090205.212708.166167413.davem@davemloft.net> (raw)
In-Reply-To: <20090206035728.GA4227@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 6 Feb 2009 14:57:28 +1100
> gro: Fix frag_list merging on imprecisely split packets
>
> The previous fix ad0f9904444de1309dedd2b9e365cae8af77d9b1 (gro:
> Fix handling of imprecisely split packets) only fixed the case
> of frags merging, frag_list merging in the same circumstances
> were still broken.
>
> In particular, the packet headers end up in the data stream.
>
> This patch fixes this plus another issue where an imprecisely
> split packet header may be read incorrectly (this is mostly
> harmless since it'll simply cause the packet to not match and
> be rejected for GRO).
>
> Thanks to Emil Tantilov and Jeff Kirsher for helping to track
> this down.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks a lot for tracking this down.
prev parent reply other threads:[~2009-02-06 5:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 3:57 gro: Fix frag_list merging on imprecisely split packets Herbert Xu
2009-02-06 5:27 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090205.212708.166167413.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=emil.s.tantilov@intel.com \
--cc=herbert@gondor.apana.org.au \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).