netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: rdreier@cisco.com, snakebyte@gmx.de, netdev@vger.kernel.org,
	yoshfuji@linux-ipv6.org
Subject: Re: Deadlock with icmpv6fuzz
Date: Fri, 06 Feb 2009 03:07:16 -0800 (PST)	[thread overview]
Message-ID: <20090206.030716.136181382.davem@davemloft.net> (raw)
In-Reply-To: <20090206103443.GA7303@gondor.apana.org.au>

From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Fri, 6 Feb 2009 21:34:43 +1100

> On Fri, Feb 06, 2009 at 09:27:10PM +1100, Herbert Xu wrote:
> >
> > But we should probably bring the check down to sysctl_optmem_max
> > in ip6_flowlabel.c too since allocating 64K is still quite likely
> > to fail and warn.
> 
> In fact, we should probably just use sock_kmalloc in these places.

Very likely we could get away with that.

But some apps might start breaking since this would now
charge the socket and we could hit the limits whereas
before we wouldn't.

  reply	other threads:[~2009-02-06 11:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-20 20:47 Deadlock with icmpv6fuzz Eric Sesterhenn
2009-01-27  5:31 ` David Miller
2009-01-27  7:53   ` Eric Sesterhenn
2009-01-28  9:35     ` Herbert Xu
2009-01-30  1:49       ` David Miller
2009-02-05 13:01         ` Herbert Xu
2009-02-05 14:31           ` Eric Sesterhenn
2009-02-05 22:24             ` Roland Dreier
2009-02-05 23:43               ` Herbert Xu
2009-02-06  8:50                 ` David Miller
2009-02-06  8:54                   ` Herbert Xu
2009-02-06  9:05                     ` David Miller
2009-02-06  9:22                       ` Herbert Xu
2009-02-06  9:27                         ` David Miller
2009-02-06 10:27                           ` Herbert Xu
2009-02-06 10:34                             ` Herbert Xu
2009-02-06 11:07                               ` David Miller [this message]
2009-02-09  5:03                                 ` Herbert Xu
2009-02-09  6:04                                   ` David Miller
2009-02-25  7:44                                   ` David Miller
2009-02-25  8:25                                     ` Herbert Xu
2009-02-06 11:05                             ` David Miller
2009-02-05 23:16           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090206.030716.136181382.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=netdev@vger.kernel.org \
    --cc=rdreier@cisco.com \
    --cc=snakebyte@gmx.de \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).