From: David Miller <davem@davemloft.net>
To: risto.suominen@gmail.com
Cc: khc@pm.waw.pl, netdev@vger.kernel.org
Subject: Re: [PATCH 002/002] de2104x: support for systems lacking cache coherence
Date: Mon, 09 Feb 2009 14:51:56 -0800 (PST) [thread overview]
Message-ID: <20090209.145156.172588416.davem@davemloft.net> (raw)
In-Reply-To: <46e1c7760902091122m6ec7fbb5nefd9cc9789880c0f@mail.gmail.com>
From: Risto Suominen <risto.suominen@gmail.com>
Date: Mon, 9 Feb 2009 21:22:03 +0200
> 2009/2/9 Krzysztof Halasa <khc@pm.waw.pl>:
> >
> > That means the consistent/coherent mapping isn't really
> > consistent/coherent (uncached), right? Perhaps there is some way to fix
> > this instead of changing the drivers to avoid the problematic area?
> >
> Yes.
>
> The other way could be to add a config parameter that allows to
> explicitly set CONFIG_NOT_COHERENT_CACHE. I have not tried this,
> probably because the necessary code wasn't in arch/powerpc until
> 2.6.21.
>
> Anyway, now I have tested with 2.6.24, and the problem still exists.
Ok.
The issue are descriptors that are _written_ by both the cpu
and the device. That is the problematic case here.
e100 had a similar problem and changes were made there too to
accomodate such system types.
If only the cpu or only the device writes to the descriptor
(which is the most common design these days) there are no
problems.
So as promised I'll have to relook at this patch :-)
next prev parent reply other threads:[~2009-02-09 22:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <46e1c7760902071330i5362fe4fvd99fc7075fc666d3@mail.gmail.com>
2009-02-09 7:27 ` Fwd: [PATCH 002/002] de2104x: support for systems lacking cache coherence Risto Suominen
2009-02-09 7:45 ` David Miller
2009-02-09 8:22 ` Risto Suominen
2009-02-09 8:29 ` David Miller
2009-02-09 8:35 ` Risto Suominen
2009-02-09 16:58 ` Krzysztof Halasa
2009-02-09 19:22 ` Risto Suominen
2009-02-09 22:51 ` David Miller [this message]
2009-02-10 1:45 ` Krzysztof Halasa
2009-02-10 1:50 ` David Miller
2009-02-10 23:21 ` David Miller
2009-02-11 12:18 ` Risto Suominen
2009-02-11 12:31 ` Risto Suominen
2009-02-11 21:39 ` David Miller
2009-02-13 3:42 ` Benjamin Herrenschmidt
2009-02-10 1:01 ` Andrew Morton
2009-02-10 1:07 ` David Miller
2009-02-10 7:16 ` Risto Suominen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209.145156.172588416.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=netdev@vger.kernel.org \
--cc=risto.suominen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).