From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH NET-NEXT 02/10] time sync: generic infrastructure to map between time stamps generated by a time counter and system time Date: Mon, 09 Feb 2009 14:57:42 -0800 (PST) Message-ID: <20090209.145742.36667502.davem@davemloft.net> References: <1233829262.20435.37.camel@pohly-MOBL> <1234198922.20325.170.camel@ecld0pohly> <1234207667.10457.53.camel@jstultz-laptop> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: patrick.ohly@intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, tglx@linutronix.de To: johnstul@us.ibm.com Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:43499 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751623AbZBIW5t (ORCPT ); Mon, 9 Feb 2009 17:57:49 -0500 In-Reply-To: <1234207667.10457.53.camel@jstultz-laptop> Sender: netdev-owner@vger.kernel.org List-ID: From: John Stultz Date: Mon, 09 Feb 2009 11:27:47 -0800 > On Mon, 2009-02-09 at 18:02 +0100, Patrick Ohly wrote: > > On Thu, 2009-02-05 at 10:21 +0000, Patrick Ohly wrote: > > > On Wed, 2009-02-04 at 21:44 +0200, john stultz wrote: > > > > On Wed, 2009-02-04 at 14:01 +0100, Patrick Ohly wrote: > > > > I sort of object to the name clocksync, as you're not really doing > > > > anything to sync clocks in the code. One, "clock" is an way overloaded > > > > term in the kernel. Two, you're really seem to be just providing deltas > > > > and skew rates between notions of time. I want to avoid someone thinking > > > > "Oh, NTP must use this code". > > > > > > > > So maybe something like timecompare.c? > > > > > > Fine with me. > > > > As there were no other comments I renamed the file, functions and struct > > accordingly. As I said in my mail, I prefer "struct timecompare" over > > "struct time_comparator". I also used "timecompare_transform()". > > > > Is this revision of the patch okay? How should the two patches get > > included in the main kernel - via netdev-next-2.6? > > > > Bye, Patrick > > Small comment below, but otherwise it looks ok to me. I usually push > patches through Andrew, so I'd probably go that way. But I'd leave it to > Dave if he's comfortable pushing them to Linus. > > Acked-by: John Stultz Patrick, please submit these two changes fresh now that all of the issues are resolved and you have the ACKs :-) I'll queue them up in net-next-2.6