From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: jeff@garzik.org, iws@ovro.caltech.edu, jacmet@sunsite.dk,
dai.haruki@freescale.com, afleming@freescale.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net] gianfar: Fix boot hangs while bringing up gianfar ethernet
Date: Mon, 09 Feb 2009 14:58:52 -0800 (PST) [thread overview]
Message-ID: <20090209.145852.156568866.davem@davemloft.net> (raw)
In-Reply-To: <20090209193440.GA2537@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Mon, 9 Feb 2009 20:34:40 +0100
> gianfar: Fix boot hangs while bringing up gianfar ethernet
>
> Ira Snyder found that commit 8c7396aebb68994c0519e438eecdf4d5fa9c7844
> "gianfar: Merge Tx and Rx interrupt for scheduling clean up ring" can
> cause hangs. It's because there was removed clearing of interrupts in
> gfar_schedule_cleanup() (which is called by an interrupt handler) in
> case when netif scheduling has been disabled. This patch brings back
> this action and a comment.
>
> Reported-by: Ira Snyder <iws@ovro.caltech.edu>
> Reported-by: Peter Korsgaard <jacmet@sunsite.dk>
> Bisected-by: Ira Snyder <iws@ovro.caltech.edu>
> Tested-by: Peter Korsgaard <jacmet@sunsite.dk>
> Tested-by: Ira Snyder <iws@ovro.caltech.edu>
> Signed-by: Jarek Poplawski <jarkao2@gmail.com>
Applied, thanks everyone.
next prev parent reply other threads:[~2009-02-09 22:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-29 19:41 [BUG BISECTED] boot hangs while bringing up gianfar ethernet Ira Snyder
2009-01-30 14:57 ` Peter Korsgaard
2009-02-07 22:55 ` Jarek Poplawski
2009-02-09 13:36 ` Peter Korsgaard
2009-02-09 13:54 ` Jarek Poplawski
2009-02-09 17:22 ` Ira Snyder
2009-02-09 19:34 ` [PATCH net] gianfar: Fix " Jarek Poplawski
2009-02-09 22:58 ` David Miller [this message]
2009-02-10 11:39 ` Jarek Poplawski
2009-02-09 19:40 ` [PATCH v2 " Jarek Poplawski
2009-02-09 22:59 ` David Miller
2009-02-09 18:53 ` [BUG BISECTED] " Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209.145852.156568866.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=afleming@freescale.com \
--cc=dai.haruki@freescale.com \
--cc=iws@ovro.caltech.edu \
--cc=jacmet@sunsite.dk \
--cc=jarkao2@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).