From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: bridge: Fix LRO crash with tun Date: Mon, 09 Feb 2009 15:07:37 -0800 (PST) Message-ID: <20090209.150737.08510604.davem@davemloft.net> References: <20090209100253.GA7232@gondor.apana.org.au> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org To: herbert@gondor.apana.org.au Return-path: Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42044 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1752751AbZBIXHn (ORCPT ); Mon, 9 Feb 2009 18:07:43 -0500 In-Reply-To: <20090209100253.GA7232@gondor.apana.org.au> Sender: netdev-owner@vger.kernel.org List-ID: From: Herbert Xu Date: Mon, 9 Feb 2009 21:02:53 +1100 > bridge: Fix LRO crash with tun ... > This crashed when an LRO packet generated by bnx2x reached a > tun device through the bridge. We're supposed to drop it at > the bridge. However, because the check was placed in br_forward > instead of __br_forward, it's only effective if we are sending > the packet through a single port. > > This patch fixes it by moving the check into __br_forward. > > Signed-off-by: Herbert Xu Applied, thanks a lot Herbert.