From: David Miller <davem@davemloft.net>
To: Santwona.Behera@Sun.COM
Cc: netdev@vger.kernel.org, gkernel-commit@lists.sourceforge.net,
jeff@garzik.org, Matheos.Worku@Sun.COM, Mehdi.Bonyadi@Sun.COM
Subject: Re: [PATCH 1/3] [ethtool] Add support for RX packet classification in a network device
Date: Mon, 09 Feb 2009 18:03:06 -0800 (PST) [thread overview]
Message-ID: <20090209.180306.156744968.davem@davemloft.net> (raw)
In-Reply-To: <4990B855.30905@Sun.COM>
From: Santwona.Behera@Sun.COM
Date: Mon, 09 Feb 2009 15:12:21 -0800
> +struct ethtool_tcpip4_spec {
> + __u32 ip4src;
> + __u32 ip4dst;
> + __u16 psrc;
> + __u16 pdst;
> + __u8 tos;
> +};
The IP addresses and ports in these new interfaces, are
they to be specified in network or cpu byte order?
That's usually the first thing a person will wonder when
trying to use to implement support for these interfaces.
My guess is that the specification is cpu endianness,
however note that this flies in the face with how this
is handled in pretty much every other networking interface
in the kernel. The standard is to use network endianness
when passing ports and IP addressing information into the
kernel.
I wouldn't reject this patch series just for this reason,
in fact I'm ready to apply this stuff, but just thought I'd
mention it just in case you hadn't considered the issue
yourself.
next prev parent reply other threads:[~2009-02-10 2:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 23:12 [PATCH 1/3] [ethtool] Add support for RX packet classification in a network device Santwona.Behera
2009-02-10 0:09 ` [gkernel-commit] " Jeff Garzik
2009-02-10 3:05 ` Santwona.Behera
2009-02-10 2:03 ` David Miller [this message]
2009-02-10 3:17 ` Santwona.Behera
2009-02-10 3:44 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2009-02-16 17:17 [PATCH 1/3] [Ethtool] " Santwona.Behera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209.180306.156744968.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Matheos.Worku@Sun.COM \
--cc=Mehdi.Bonyadi@Sun.COM \
--cc=Santwona.Behera@Sun.COM \
--cc=gkernel-commit@lists.sourceforge.net \
--cc=jeff@garzik.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).