From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jeff Chua <jeff.chua.linux@gmail.com>
Cc: David Miller <davem@davemloft.net>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Linus Torvalds <torvalds@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 breaks rlogin
Date: Mon, 9 Feb 2009 16:58:48 +1100 [thread overview]
Message-ID: <20090209055848.GA3889@gondor.apana.org.au> (raw)
In-Reply-To: <b6a2187b0902060335h646e8d86pf00773035f577665@mail.gmail.com>
On Fri, Feb 06, 2009 at 07:35:50PM +0800, Jeff Chua wrote:
>
> > Did you change the kernel on the other side during these tests?
>
> No. Was hoping that the traces would show where it hang for the good
> and bad trace.
Then the problem isn't my patch at all. My patch only affects
the side sending the urgent data, according to your straces, rlogin
is only receiving urgent data, not sending it. So the patch cannot
have an affect.
> > If reverting the patch on the other side does fix the problem
> > for you, please do the two straces there.
>
> Sorry, forgot to send the good trace run for the patched remote side.
> Here's attached. t5.good.
No you're still stracing rlogin, which in this case is the receiver
of the urgent data. Please strace the sending side, which would be
presumably be rlogind in this case.
Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2009-02-09 5:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <b6a2187b0902050641h7943816ds26275a320e724440@mail.gmail.com>
2009-02-05 23:29 ` commit 64ff3b938ec6782e6585a83d5459b98b0c3f6eb8 breaks rlogin David Miller
2009-02-05 23:32 ` Linus Torvalds
2009-02-05 23:38 ` David Miller
2009-02-05 23:52 ` Herbert Xu
[not found] ` <20090206031025.GA3281@gondor.apana.org.au>
2009-02-06 5:39 ` Jeff Chua
2009-02-06 5:45 ` Herbert Xu
2009-02-06 11:35 ` Jeff Chua
2009-02-09 5:58 ` Herbert Xu [this message]
2009-02-09 6:03 ` David Miller
2009-02-09 6:11 ` Herbert Xu
2009-02-09 7:13 ` Ilpo Järvinen
2009-02-09 7:28 ` Herbert Xu
2009-02-09 7:33 ` Herbert Xu
2009-02-09 13:28 ` Ilpo Järvinen
2009-02-21 13:24 ` Herbert Xu
2009-02-21 18:54 ` Ilpo Järvinen
2009-02-22 7:53 ` David Miller
2009-02-24 6:40 ` Jeff Chua
2009-02-24 6:44 ` Herbert Xu
2009-02-24 6:46 ` David Miller
2009-02-24 8:01 ` Jeff Chua
2009-02-09 14:10 ` Jeff Chua
2009-02-09 15:44 ` Linus Torvalds
2009-02-09 21:17 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090209055848.GA3889@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox