From: David Miller <davem@davemloft.net>
To: yanghy@cn.fujitsu.com
Cc: netdev@vger.kernel.org, dhananjay@netxen.com
Subject: Re: [PATCH]netxen:fix compile waring "label ‘set_32_bit_mask’ defined but not used" on IA64 platform
Date: Thu, 12 Feb 2009 16:58:03 -0800 (PST) [thread overview]
Message-ID: <20090212.165803.36812932.davem@davemloft.net> (raw)
In-Reply-To: <4993D7E7.5060300@cn.fujitsu.com>
From: Yang Hongyang <yanghy@cn.fujitsu.com>
Date: Thu, 12 Feb 2009 16:03:51 +0800
> When compile the latest kernel on IA64 platform,I got a warning:
> drivers/net/netxen/netxen_nic_main.c:203: warning: label ‘set_32_bit_mask’
> defined but not used
>
> We do not need label ‘set_32_bit_mask’ on IA64 platform,So move it to #else.
>
> Signed-off-by: Yang Hongyang<yanghy@cn.fujitsu.com>
Applied.
Although I think this whole CONFIG_IA64 ifdef business should
be eliminated entirely. You cannot tell me that we don't
have the generic interfaces necessary to make a proper
decision on dma mask selection in this bit of code.
prev parent reply other threads:[~2009-02-13 0:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 8:03 [PATCH]netxen:fix compile waring "label ‘set_32_bit_mask’ defined but not used" on IA64 platform Yang Hongyang
2009-02-13 0:58 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212.165803.36812932.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dhananjay@netxen.com \
--cc=netdev@vger.kernel.org \
--cc=yanghy@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).