From: David Miller <davem@davemloft.net>
To: clement.lecigne@netasq.com
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] 4 bytes kernel memory disclosure in SO_BSDCOMPAT gsopt try #2
Date: Thu, 12 Feb 2009 16:59:24 -0800 (PST) [thread overview]
Message-ID: <20090212.165924.220333032.davem@davemloft.net> (raw)
In-Reply-To: <20090212123545.GA46788@clem1.netasq.com>
From: Clement LECIGNE <clement.lecigne@netasq.com>
Date: Thu, 12 Feb 2009 13:35:45 +0100
> In function sock_getsockopt() located in net/core/sock.c, optval v.val
> is not correctly initialized and directly returned in userland in case
> we have SO_BSDCOMPAT option set.
>
> This dummy code should trigger the bug:
>
> int main(void)
> {
> unsigned char buf[4] = { 0, 0, 0, 0 };
> int len;
> int sock;
> sock = socket(33, 2, 2);
> getsockopt(sock, 1, SO_BSDCOMPAT, &buf, &len);
> printf("%x%x%x%x\n", buf[0], buf[1], buf[2], buf[3]);
> close(sock);
> }
>
> Here is a patch that fix this bug by initalizing v.val just after its declaration.
Applied, thank you.
prev parent reply other threads:[~2009-02-13 0:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-12 12:35 [PATCH] 4 bytes kernel memory disclosure in SO_BSDCOMPAT gsopt try #2 Clement LECIGNE
2009-02-13 0:59 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090212.165924.220333032.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=clement.lecigne@netasq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).