From: David Miller <davem@davemloft.net>
To: jarkao2@gmail.com
Cc: vladislav.yasevich@hp.com, ole@ans.pl, pupilla@hotmail.com,
netdev@vger.kernel.org
Subject: Re: WARNING: at net/core/skbuff.c:154 with tcpdump and ipsec
Date: Fri, 13 Feb 2009 18:24:26 -0800 (PST) [thread overview]
Message-ID: <20090213.182426.175113018.davem@davemloft.net> (raw)
In-Reply-To: <20090213200014.GB2929@ami.dom.local>
From: Jarek Poplawski <jarkao2@gmail.com>
Date: Fri, 13 Feb 2009 21:00:14 +0100
> On Fri, Feb 13, 2009 at 02:42:07PM -0500, Vlad Yasevich wrote:
> ...
> > Personally, I think pskb_expand_head should fix the skb->truesize. This
> > way any subsequent clones will not trigger this warning.
>
> Personally, I think there is no reason to call skb_truesize_bug() in
> anything but some #ifdef CONFIG_XX_DEBUG, if we ignore these reports
> for so long.
If skb->sk is non-NULL, fixing up the truesize will corrupt
socket memory accounting.
Anyways, Herbert and I have talked about %100 removing the
warning.
next prev parent reply other threads:[~2009-02-14 2:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 15:26 WARNING: at net/core/skbuff.c:154 with tcpdump and ipsec Marco Berizzi
2009-02-11 15:55 ` Krzysztof Oledzki
2009-02-11 18:25 ` Jarek Poplawski
2009-02-13 12:14 ` Jarek Poplawski
2009-02-13 18:56 ` Vlad Yasevich
2009-02-13 19:24 ` Jarek Poplawski
2009-02-13 19:42 ` Vlad Yasevich
2009-02-13 20:00 ` Jarek Poplawski
2009-02-14 2:24 ` David Miller [this message]
2009-02-18 9:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090213.182426.175113018.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jarkao2@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=ole@ans.pl \
--cc=pupilla@hotmail.com \
--cc=vladislav.yasevich@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).